Re: [PATCH] ARM: tegra: make Venice's +3.3V_RUN regulator always on

[Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]

On 04/15/2014 06:54 PM, Andrew Bresticker wrote:
> On Tue, Apr 15, 2014 at 3:29 PM, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>
>> This regulator supplies power to pretty much everything on the board, so
>> it doesn't make sense to allow it to turn off. Mark it boot-on and
>> always-on so it doesn't get turned off. Without this, I see issues with
>> the eMMC device; it can't be correctly detected during boot.
> 
> This actually isn't a complete fix.  +3V3_RUN will still toggle on a
> cold boot because the GPIO1_INVERT bit is initialized by the PMIC to
> 1, but when the regulator core requests the GPIO as an output,
> as3722_gpio_direction_output() first sets the output value to 1
> (without considering the INVERT bit!) and then clears the invert bit
> when setting the mode in as3722_pinctrl_gpio_set_direction().  The
> as3722 driver should probably not touch the INVERT bit and instead
> just take it into account when setting the GPIO value.

I'll take that as a heads-up on the existence of the AS3722 GPIO patch,
rather than an objection to this patch.