From: Stephen Warren <swarren@wwwdotorg.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: linux-tegra@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/16] Another 16 L2C patches
Date: Mon, 28 Apr 2014 12:08:11 -0600 [thread overview]
Message-ID: <535E990B.2020405@wwwdotorg.org> (raw)
In-Reply-To: <20140428173943.GN26756@n2100.arm.linux.org.uk>
(Dropping most people from CC since this sub-thread is a Tegra-specific
discussion)
On 04/28/2014 11:39 AM, Russell King - ARM Linux wrote:
> On Mon, Apr 28, 2014 at 11:27:09AM -0600, Stephen Warren wrote:
...
>> I do see one error in dmesg during boot, but it doesn't appear to
>> negatively affect operation in brief testing, and is present in
>> linux-next without this series anyway. Is this message a problem?
>>
>>> [ 0.000000] L2C: platform modifies aux control register: 0x02080000 -> 0x3e480001
>>> [ 0.000000] L2C: DT/platform modifies aux control register: 0x02080000 -> 0x3e480001
>>> [ 0.000000] L2C-310 errata 727915 769419 enabled
>>> [ 0.000000] L2C-310 enabling early BRESP for Cortex-A9
>>> [ 0.000000] L2C-310: enabling full line of zeros but not enabled in Cortex-A9
>> ^^^^^^ this is logged at error level
>
> Correct, it's an error because on Tegra you explicitly set bit 0 in the
> auxiliary control register, which is pointless unless the feature is
> also enabled in the Cortex-A9 control register as well.
Please forgive my almost complete lack of knowledge re: cache
controllers. Is the correct fix for this:
a) To remove bit 0 from the aux_val passed to l2x0_of_init()
b) To set some BIT(3) in the Cortex-A9 auxcr, so this feature is enabled
there too.
And if (b), I assume that's something that the bootloader should be
doing, not the kernel?
Thanks.
next prev parent reply other threads:[~2014-04-28 18:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 16:56 [PATCH 00/16] Another 16 L2C patches Russell King - ARM Linux
2014-04-28 16:58 ` [PATCH 07/16] ARM: l2c: convert tegra to generic l2c initialisation Russell King
2014-04-28 17:28 ` Stephen Warren
2014-04-28 17:41 ` Russell King - ARM Linux
2014-04-28 17:12 ` [PATCH 00/16] Another 16 L2C patches Stephen Warren
2014-04-28 17:27 ` Stephen Warren
2014-04-28 17:39 ` Russell King - ARM Linux
2014-04-28 18:08 ` Stephen Warren [this message]
2014-04-28 18:19 ` Russell King - ARM Linux
2014-04-28 18:40 ` Stephen Warren
[not found] ` <535EA090.6030903-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-04-28 19:10 ` Russell King - ARM Linux
2014-04-28 19:00 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535E990B.2020405@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pdeschrijver@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox