From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/2] ARM: tegra: joystick input in tegra_defconfig Date: Tue, 13 May 2014 09:39:02 -0600 Message-ID: <53723C96.5020203@wwwdotorg.org> References: <1399883209-31169-1-git-send-email-acourbot@nvidia.com> <1399883209-31169-2-git-send-email-acourbot@nvidia.com> <5370F794.2020800@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexandre Courbot Cc: Alexandre Courbot , Thierry Reding , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Linux Kernel Mailing List List-Id: linux-tegra@vger.kernel.org On 05/12/2014 09:45 PM, Alexandre Courbot wrote: > On Tue, May 13, 2014 at 1:32 AM, Stephen Warren wrote: >> On 05/12/2014 02:26 AM, Alexandre Courbot wrote: >>> NVIDIA SHIELD embeds a USB controller. Compile the corresponding support >>> as a module in tegra_defconfig. >> >> Why make this a module rather than built-in. Almost everything else in >> tegra_defconfig is built-in, except brcmfmac since it doesn't handle >> lack of firmware availability at probe time. > > Goal is to minimize the image size, especially since this is not a > feature I expect to be used much outside of SHIELD. If you prefer it > built-in, I'm fine with it too. Yes, built-in for everything makes most sense to me, except for code that doesn't actually work unless it's a module.