From: Stephen Warren <swarren@wwwdotorg.org>
To: Thierry Reding <thierry.reding@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Andrew Bresticker <abrestic@chromium.org>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] pinctrl: Add NVIDIA Tegra XUSB pad controller support
Date: Thu, 05 Jun 2014 11:08:54 -0600 [thread overview]
Message-ID: <5390A426.1050307@wwwdotorg.org> (raw)
In-Reply-To: <1401894990-30092-1-git-send-email-thierry.reding@gmail.com>
On 06/04/2014 09:16 AM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The XUSB pad controller found on NVIDIA Tegra SoCs provides several pads
> that lanes can be assigned to in order to support a variety of interface
> options: USB 2.0, USB 3.0, PCIe and SATA.
>
> In addition to the pin controller used to assign lanes to pads two PHYs
> are exposed to allow the bricks for PCIe and SATA to be powered up and
> down by PCIe and SATA drivers.
> +#define TEGRA124_GROUP(_funcs) \
> + { \
> + .num_funcs = ARRAY_SIZE(tegra124_##_funcs##_functions), \
> + .funcs = tegra124_##_funcs##_functions, \
> + }
> +
> +static const struct tegra_xusb_padctl_group tegra124_groups[] = {
> + TEGRA124_GROUP(otg),
> + TEGRA124_GROUP(usb),
> + TEGRA124_GROUP(pci),
> +};
I'm not sure what this set of groups is for.
pinctrl muxes functions onto groups, so given that each pin in padctl is
individually configurable, we need 1 group per pin. As far as I can
tell, tegra_xusb_padctl_get_groups_count()/name() implement this
correctly, and this array isn't used anywhere?
next prev parent reply other threads:[~2014-06-05 17:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 15:16 [PATCH 1/4] pinctrl: Add NVIDIA Tegra XUSB pad controller support Thierry Reding
2014-06-04 15:16 ` [PATCH 2/4] of: Add NVIDIA Tegra XUSB pad controller binding Thierry Reding
2014-06-05 16:47 ` Stephen Warren
[not found] ` <53909F31.4050603-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-05 22:08 ` Thierry Reding
2014-06-05 22:57 ` Stephen Warren
[not found] ` <5390F5C7.5070301-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-12 8:46 ` Linus Walleij
2014-06-04 15:16 ` [PATCH 3/4] ARM: tegra: tegra124: Add XUSB pad controller Thierry Reding
2014-06-04 15:16 ` [PATCH 4/4] ARM: tegra: jetson-tk1: " Thierry Reding
2014-06-05 17:08 ` Stephen Warren [this message]
[not found] ` <5390A426.1050307-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-05 22:09 ` [PATCH 1/4] pinctrl: Add NVIDIA Tegra XUSB pad controller support Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5390A426.1050307@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=abrestic@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox