From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikko Perttunen Subject: Re: [PATCH v2 6/7] ata: Add support for the Tegra124 SATA controller Date: Mon, 14 Jul 2014 09:21:51 +0300 Message-ID: <53C376FF.3060509@nvidia.com> References: <1403101406-15439-1-git-send-email-mperttunen@nvidia.com> <1403101406-15439-7-git-send-email-mperttunen@nvidia.com> <20140708132216.GA4979@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140708132216.GA4979@htj.dyndns.org> Sender: linux-ide-owner@vger.kernel.org To: Hans de Goede Cc: Tejun Heo , "swarren@wwwdotorg.org" , "thierry.reding@gmail.com" , Peter De Schrijver , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-ide@vger.kernel.org" List-Id: linux-tegra@vger.kernel.org Hi Hans, have you been able to take a look at this? Thanks, Mikko On 08/07/14 16:22, Tejun Heo wrote: > (cc'ing Hans) > > Hans, can you please review this patch? > > On Wed, Jun 18, 2014 at 05:23:25PM +0300, Mikko Perttunen wrote: >> +#define SATA_CONFIGURATION_0 0x180 >> +#define SATA_CONFIGURATION_EN_FPCI BIT(0) > > Let's just indent uniformly. The new line should give enough visual > hint on grouping. > >> +struct tegra_ahci_priv { >> + struct platform_device *pdev; >> + void __iomem *sata_regs; >> + struct reset_control *sata_rst; >> + struct reset_control *sata_oob_rst; >> + struct reset_control *sata_cold_rst; >> + struct clk *sata_clk; >> + struct clk *sata_oob_clk; >> + struct clk *cml1_clk; >> + struct clk *plle_clk; >> + struct regulator_bulk_data supplies[5]; >> + struct phy *padctl_phy; >> +}; > > And please indent the declared fields uniformly too. > > Except for the above nitpicks, generally looks good to me but let's > wait for Hans' review. > > Thanks. >