From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 4/4] ARM: tegra: roth: add display DT node Date: Mon, 21 Jul 2014 09:35:27 -0600 Message-ID: <53CD333F.2070805@wwwdotorg.org> References: <1404303560-32209-1-git-send-email-acourbot@nvidia.com> <1404303560-32209-5-git-send-email-acourbot@nvidia.com> <53B42B60.1000600@wwwdotorg.org> <53B4C9C0.4000605@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53B4C9C0.4000605@nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexandre Courbot , Thierry Reding Cc: "linux-tegra@vger.kernel.org" , Terje Bergstrom , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" List-Id: linux-tegra@vger.kernel.org On 07/02/2014 09:10 PM, Alexandre Courbot wrote: > On 07/03/2014 12:55 AM, Stephen Warren wrote: >> On 07/02/2014 06:19 AM, Alexandre Courbot wrote: >>> DSI support has been fixed to support continuous clock behavior that the >>> panel used on SHIELD requires, so finally add its device tree node since >>> it is functional. >> >>> diff --git a/arch/arm/boot/dts/tegra114-roth.dts >>> b/arch/arm/boot/dts/tegra114-roth.dts >> >>> + host1x@50000000 { >>> + dsi@54300000 { >> >> That node looks fine, but I wonder why we need to mark a bunch of >> regulators as always-on? shouldn't the references to vdd-supply and >> power-supply from this node be enough? If not, perhaps the tree >> structure of the regulators isn't correct, or the DSI or panel bindings >> don't allow enough regulators to be referenced? > > regulator-always-on is indeed not needed for vdd_lcd. I actually had a > patch in my tree removing this line that I forgot to squash. Will post a > v2 for this patch that fixes this, thanks. > > vdd-2v8-display needs to remain always-on however. Here we may hit a > limitation of the simple-panel driver, where only one power supply can > be provided. Can't we fix the simple-panel driver to allow a list of regulators in the property? I suppose that this technique is OK though; we can always simplify the DT later if the simple-panel binding gets enhanced.