[PATCH tegra-uboot-scripts v2] Make folder for dtb files as an argument

[PATCH tegra-uboot-scripts v2] Make folder for dtb files as an argument

[Stefan Agner]

Some distribution use different folders to store the dtb files
rather then storing them directly in /boot. This adds a new
argument to define which folder U-Boot should search the dtb
file.

Signed-off-by: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
---
 gen-uboot-script.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gen-uboot-script.py b/gen-uboot-script.py
index 8ca3d01..47de520 100755
--- a/gen-uboot-script.py
+++ b/gen-uboot-script.py
@@ -71,6 +71,9 @@ parser.add_argument('--noisy', action='store_true',
 parser.add_argument('--cmdline',
     help='Extra command-line options')
 
+parser.add_argument('--dtb-dir', dest='dtbdir', default=None,
+    help='Search directory for dtbs on target; defaults to /boot')
+
 args = parser.parse_args()
 if args.debug: print args
 
@@ -107,7 +110,10 @@ if args.type == 'net':
     prefix=''
 else:
     load='load ${devtype} ${devnum}:${rootpart}'
-    prefix='/boot/'
+    if not args.dtbdir:
+        prefix='/boot/'
+    else:
+        prefix=args.dtbdir+'/'
 
 f.write(load + ' ${kernel_addr_r} ' + prefix + 'zImage\n')
 
-- 
2.0.2

Re: [PATCH tegra-uboot-scripts v2] Make folder for dtb files as an argument

[Stephen Warren]

On 07/24/2014 03:55 PM, Stefan Agner wrote:
> Some distribution use different folders to store the dtb files
> rather then storing them directly in /boot. This adds a new
> argument to define which folder U-Boot should search the dtb
> file.

> diff --git a/gen-uboot-script.py b/gen-uboot-script.py

> @@ -107,7 +110,10 @@ if args.type == 'net':
>       prefix=''
>   else:
>       load='load ${devtype} ${devnum}:${rootpart}'
> -    prefix='/boot/'
> +    if not args.dtbdir:
> +        prefix='/boot/'
> +    else:
> +        prefix=args.dtbdir+'/'
>
>   f.write(load + ' ${kernel_addr_r} ' + prefix + 'zImage\n')

I don't think this is right; it makes --dtbdir affect the value of the 
prefix variable, which is used for all of zImage, DTBs, and initrd. I 
didn't think that's what you wanted, although if it is, then (a) the 
option doesn't have the right name, and (b), it should presumably affect 
network mode too.