From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikko Perttunen Subject: Re: [PATCH] clk: tegra: Implement memory-controller clock Date: Mon, 4 Aug 2014 09:35:20 +0300 Message-ID: <53DF29A8.1030604@nvidia.com> References: <1406894945-32069-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1406894945-32069-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding , Peter De Schrijver , Prashant Gaikwad Cc: Mike Turquette , Stephen Warren , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org I'm curious why you used emc_mux as the parent clock? (I don't really understand why this clock exists, and my EMC series removes it). Using 'emc' would be compatible with the EMC series :) A minor one: the MC clock should probably be always enabled. Apart from these: Reviewed-by: Mikko Perttunen Tested-by: Mikko Perttunen Cheers, Mikko On 01/08/14 15:09, Thierry Reding wrote: > From: Thierry Reding > > The memory controller clock runs either at half or the same frequency as > the EMC clock. > > Signed-off-by: Thierry Reding > ...