linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Dylan Reid <dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Andrew Bresticker
	<abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	"olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org"
	<olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Subject: Re: [PATCH 1/2] ARM: tegra: add Acer Chromebook 13 device tree
Date: Wed, 13 Aug 2014 13:56:28 -0600	[thread overview]
Message-ID: <53EBC2EC.1010300@wwwdotorg.org> (raw)
In-Reply-To: <CAEUnVG6ki9O5hzw9OvJ1+8Www_G1+rqXujmNyJy+qOP-z_JR=A@mail.gmail.com>

On 08/13/2014 01:07 PM, Dylan Reid wrote:
> On Wed, Aug 13, 2014 at 10:10 AM, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
>> On 08/12/2014 07:56 PM, Dylan Reid wrote:
>>>
>>> The Acer Chromebook 13, codenamed "Big", contains an NVIDIA tegra124
>>> processor and is similar to the Venice2 reference platform.
>>>
>>> The keyboard, USB 2, audio, HDMI, sdcard and emmc have been tested
>>> and work on the 1366x768 models.  I haven't tried on the HD systems
>>> yet.
>>>
>>> WiFi does not yet work, it needs at least some PMIC changes to enable
>>> the 32k clock.
>>>
>>> The elan trackpad is not yet functional but hopefully will be soon as
>>> there are patches under review.
>>>
>>> There is also an issue on reboot because the TPM isn't reset.  It will
>>> cause the stock firmware to enter recovery mode.  This can be worked
>>> around by an EC-reset, press refresh and power at the same time.
>>
>>
>>> diff --git a/arch/arm/boot/dts/tegra124-big.dts
>>> b/arch/arm/boot/dts/tegra124-big.dts
>>
>>
>> I think we need to include the SKU name in the filename and compatible value
>> below, or at least plan out that for other SKUs, we'll add the SKU name on.
>>
>>
>>> +/ {
>>> +       model = "Google Big";
>>> +       compatible = "google,nyan-big", "nvidia,tegra124";
>>
>>
>> I think it'd be more user-friendly if the filename and compatible value more
>> obviously tied to the end-user-visible product name.
>
> I'll change the model to "Acer Chromebook 13"

Would mentioning "CB5" in the model be a good idea; that's what it's 
sold as.

> If we need a separate DT for the FullHD skew, then can we add a file
> 'tegra124-nyan-big-full-hd.dtsi'?  We may also add
> 'tegra124-nyan-big-full-hd-touch.dtsi' as well.  They would just
> override the necessary things from this file.

*.dts rather than *.dtsi I suspect? Yes, having a common include file 
and separate top-level files sounds like a good idea.

>>> +       gpio-keys {
>>> +               compatible = "gpio-keys";
>>> +
>>> +               lid {
>>> +                       label = "Lid";
>>> +                       gpios = <&gpio TEGRA_GPIO(R, 4) GPIO_ACTIVE_LOW>;
>>> +                       linux,input-type = <5>;
>>> +                       linux,code = <0>;
>>
>>
>> Aren't there #defines for the 5 and 0 there?
>
> yes for code, apparently not for input-type.  I think 5 means EV_SW,
> maybe that should get added to include/dt-bindings/input somewhere?

Yes, that sounds like a good idea.

  reply	other threads:[~2014-08-13 19:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-13  1:56 [PATCH 1/2] ARM: tegra: add Acer Chromebook 13 device tree Dylan Reid
     [not found] ` <1407894967-18300-1-git-send-email-dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-08-13  8:53   ` Thierry Reding
2014-08-13 16:23     ` Andrew Bresticker
2014-08-13 16:51     ` Olof Johansson
     [not found]       ` <CAOesGMg2uZ8-ypeuSXJoSN3mz6jBjNwLbTo9EiXOf2D7iVCfiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-13 16:57         ` Stephen Warren
2014-08-13 16:51     ` Stephen Warren
     [not found]       ` <53EB9786.6010809-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-08-13 16:55         ` Olof Johansson
2014-08-13 17:04         ` Andrew Bresticker
     [not found]           ` <CAL1qeaGxcp4okVTYCMj0zMh-4HzsGLBvngv0+A1m8o3sZPDj2A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-13 17:12             ` Stephen Warren
     [not found]               ` <53EB9C61.1070406-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-08-13 17:17                 ` Andrew Bresticker
2014-08-13 18:42     ` Dylan Reid
2014-08-13 17:10   ` Stephen Warren
     [not found]     ` <53EB9BF0.9010002-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-08-13 17:23       ` Olof Johansson
     [not found]         ` <CAOesGMhAzx==sXnHBg4dhAtO3=JP-s-MmzujskctA=7OUC0uRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-13 17:31           ` Stephen Warren
     [not found]             ` <53EBA0ED.30607-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-08-13 17:37               ` Olof Johansson
     [not found]                 ` <CAOesGMgeLbuURwA1VVxkLp=vH9PB_VdUHFJthH=ae-_ZDVYyAA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-13 20:17                   ` Stephen Warren
2014-08-13 19:07       ` Dylan Reid
2014-08-13 19:56         ` Stephen Warren [this message]
     [not found]           ` <53EBC2EC.1010300-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-08-14  8:40             ` Dylan Reid
2015-01-13 17:49   ` Tomeu Vizoso
     [not found]     ` <CAAObsKCbJLwEHeiv3DbCwsiVSZ0VDGzU84+ipPKJQZajx+KiuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-14  0:32       ` Dylan Reid
2015-01-14  7:02         ` Tomeu Vizoso
     [not found]           ` <CAAObsKBo13fEy72EQe3V409fEEYpw0kQss5UgaOhk=GOVEEeYg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-15  7:50             ` Thierry Reding
2015-01-15 12:18               ` Tomeu Vizoso
2015-01-15 17:18               ` Stephen Warren
2015-01-19  9:01   ` Tomeu Vizoso
     [not found]     ` <CAAObsKA9EgdmqAe8JxJ=8nKJy6MsenHv8cpDO6fBiutBtgEpGw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-19 19:29       ` Andrew Bresticker
  -- strict thread matches above, loose matches on Subject: below --
2014-08-13  2:54 Dylan Reid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53EBC2EC.1010300@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).