From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v2] ARM: tegra: add Acer Chromebook 13 device tree Date: Mon, 18 Aug 2014 17:43:12 -0600 Message-ID: <53F28F90.3000004@wwwdotorg.org> References: <1407957267-3258-1-git-send-email-dgreid@chromium.org> <53EF76CF.9050808@suse.de> <53F2255E.7090208@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Bresticker Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Dylan Reid , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Thierry Reding , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Olof Johansson List-Id: linux-tegra@vger.kernel.org On 08/18/2014 05:24 PM, Andrew Bresticker wrote: > On Mon, Aug 18, 2014 at 9:10 AM, Stephen Warren wrote: >> On 08/16/2014 09:20 AM, Andreas F=C3=A4rber wrote: >>> >>> Hi, >>> >>> Am 13.08.2014 21:14, schrieb Dylan Reid: >>>> >>>> The Acer Chromebook 13, codenamed Big, contains an NVIDIA tegra124 >>>> processor and is similar to the Venice2 reference platform. >>>> >>>> The keyboard, USB 2, audio, HDMI, sdcard, and emmc have been teste= d >>>> and work on the 1266x768 models. The HD models haven't yet been >>>> tested. >>>> >>>> WiFi does not work yet, it needs at least some PMIC changes to ena= ble >>>> the 32k clock. >>>> >>>> The elan trackpad is not yet functional but hopefully will be soon= as >>>> there are patches under review. >>>> >>>> There is also an issue on reboot because the TPM isn't reset. It = will >>>> cause the stock firmware to enter recovery mode. This can be work= ed >>>> around by an EC-reset, press the refresh and power keys at the sam= e >>>> time. >> >> >>>> diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts >>>> b/arch/arm/boot/dts/tegra124-nyan-big.dts >>>> new file mode 100644 >>>> index 0000000..79f1852 >>>> --- /dev/null >>>> +++ b/arch/arm/boot/dts/tegra124-nyan-big.dts >>>> @@ -0,0 +1,1136 @@ >>>> +/dts-v1/; >>>> + >>>> +#include >>>> +#include "tegra124.dtsi" >>>> + >>>> +/ { >>>> + model =3D "Acer Chromebook 13"; >>>> + compatible =3D "google,nyan-big", "nvidia,tegra124"; >>> >>> >>> In light of v1 and the above commit message referring to this as Go= ogle >>> Big, shouldn't this be "google,big", "nvidia,tegra124" and optional= ly >>> "google,nyan" as secondary string, independent of the new file name= ? >> >> >> Despite this board having been derived from Nyan, it isn't Nyan, so = I don't >> think Nyan should be part of any compatible value, nor a separate co= mpatible >> value. > > "google,nyan-big" is the compatible string that the bootloader on > these devices looks for. It's also the convention we are now using > for our ARM devices, as Olof has already mentioned. I don't understand "that the bootloader looks for"; why is the=20 bootloader doing anything w.r.t the compatible value in the DT that's=20 passed to the kernel. Olof also mentioned that if I had any better ideas on file naming, I=20 should point them out. As I mentioned in response, there's zero need fo= r=20 all the files or compatible values to have "nyan" in them in order to=20 include any common .dtsi file, which was the justification for having=20 "nyan" in the filename, IIRC. Again, this board *isn't* Nyan, so it should pretend that it is.