From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Ni Subject: Re: [PATCH v3 4/4] ARM: tegra: dalmore: add thermal zones for nct1008 Date: Tue, 26 Aug 2014 10:24:42 +0800 Message-ID: <53FBEFEA.8050706@nvidia.com> References: <1408948188-4181-1-git-send-email-wni@nvidia.com> <1408948188-4181-5-git-send-email-wni@nvidia.com> <20140825111041.GC12349@developer> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140825111041.GC12349@developer> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eduardo Valentin Cc: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 08/25/2014 07:10 PM, Eduardo Valentin wrote: > On Mon, Aug 25, 2014 at 02:29:48PM +0800, Wei Ni wrote: >> From: lightning314 >> >> Add dt node to describe the thermal zone for the nct1008. >> >> Signed-off-by: Wei Ni >> --- >> arch/arm/boot/dts/tegra114-dalmore.dts | 20 +++++++++++++++++++- >> 1 file changed, 19 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts >> index 5c21d21..94a1b5d 100644 >> --- a/arch/arm/boot/dts/tegra114-dalmore.dts >> +++ b/arch/arm/boot/dts/tegra114-dalmore.dts >> @@ -779,12 +779,14 @@ >> <&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_HIGH>; >> }; >> >> - temperature-sensor@4c { >> + nct1008: temperature-sensor@4c { >> compatible = "onnn,nct1008"; >> reg = <0x4c>; >> vcc-supply = <&palmas_ldo6_reg>; >> interrupt-parent = <&gpio>; >> interrupts = ; >> + >> + #thermal-sensor-cells = <1>; >> }; >> }; >> >> @@ -1283,4 +1285,20 @@ >> <&tegra_car TEGRA114_CLK_EXTERN1>; >> clock-names = "pll_a", "pll_a_out0", "mclk"; >> }; >> + >> + thermal-zones { >> + nct1008-local { > > at this level, can the thermal zone name be a meaningful string? What > part of the hardware does the local and remote monitors the the dalmore > platform? Oh, yes, you are right. I think it's better to use "board_thermal_sensor: nct1008-local" and "diode_thermal_sensor: nct1008-remote". Thanks. Wei. > >> + polling-delay-passive = <2000>; /* milliseconds */ >> + polling-delay = <0>; /* milliseconds */ >> + >> + thermal-sensors = <&nct1008 0>; >> + }; >> + >> + nct1008-remote { >> + polling-delay-passive = <1000>; /* milliseconds */ >> + polling-delay = <0>; /* milliseconds */ >> + >> + thermal-sensors = <&nct1008 1>; >> + }; >> + }; >> }; >> -- >> 1.8.1.5 >>