From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v2 1/4] clk: tegra: Move mipi-cal initialization into clk-tegra1[12]4.c Date: Wed, 10 Sep 2014 10:17:44 -0600 Message-ID: <541079A8.9080304@wwwdotorg.org> References: <1410360725-4286-1-git-send-email-seanpaul@chromium.org> <1410360725-4286-2-git-send-email-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1410360725-4286-2-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter De Schrijver Cc: Sean Paul , thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 09/10/2014 08:52 AM, Sean Paul wrote: > This patch moves the mipi-cal gate registration down into the SoC > specific files to reflect the different in parent between them. > > Without this change, MIPI calibration will fail on K1 devices if > the 72MHz clock is off. This isn't a problem with this patch per se, but I notice that what's removed from clk-tegra-periph.c is data in a table, whereas open-coded calls are added to clk-tegra*.c. It'd be nice if the open-coded calls in clk-tegra*.c could be converted to a table (simply with SoC-specific data) and processed by the same function. Peter, would that make sense?