Re: [PATCH 2/2] clocksource: tegra: Register watchdog device

Thierry Reding
2014-10-14T10:42:19Z

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

On Mon, Oct 13, 2014 at 09:42:10AM -0700, Guenter Roeck wrote:
> On 10/13/2014 05:05 AM, Thierry Reding wrote:
> >From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >
> >The watchdog timer is part of the timer controller block on Tegra. In
> >order to avoid access to the same registers from two drivers, register
> >the watchdog device from the clocksource driver.
> >
> >Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Does that really make sense ?
>
> A couple of callbacks into the clock driver to implement register accesses
> might be a better approach.

I guess that would be a valid approach as well. It has the downside of
requiring the addition of at least two globally visible symbols to the
kernel. It also means that we'd need to somehow pass around a struct
device for diagnostic messages and so on. Dealing with all of that seems
like much more of a burden than this.

Also if you look at the diffstat this approach allows us to get rid of
80 lines of code. Adding a custom mechanism to share the register space
would be more likely to result in a positive diffstat.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]