public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: James Thomas
	<james.thomas-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [flasher PATCH] Set bootdelay to 0
Date: Mon, 01 Dec 2014 11:05:43 -0700	[thread overview]
Message-ID: <547CADF7.8030506@wwwdotorg.org> (raw)
In-Reply-To: <1417024626-6616-2-git-send-email-james.thomas-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>

On 11/26/2014 10:57 AM, James Thomas wrote:
> On 32-bit systems fdtput writes 0xfffffffe as 0x7fffffff, which takes
> some time to complete.
>
> Setting this to 0 accomplishes the same goal

A value of 0 doesn't mean the same thing. 0 means that bootdelay is 
enabled, just with an immediate timeout, whereas -2 means that bootdelay 
is disabled completely, so that boot can't be interrupted. The 
difference is that when bootdelay is 0, the user can still press a key 
before the boot delay check, and break into the boot process. This would 
make the flasher less reliable.

Can you explain why the correct value doesn't get into the DTB? It seems 
better to fix that bug in fdtput instead. Or perhaps there's a bug in 
the command-line arguments to fdtput that should be fixed?

BTW, you don't need to send a cover letter when you're only sending one 
patch. In fact, even with a multi-patch series, you can often get away 
without a cover letter assuming all the patch descriptions are complete, 
which they should be anwyay:-)

  parent reply	other threads:[~2014-12-01 18:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 17:57 [flasher PATCH] Set a boot delay of 0 instead of -2 James Thomas
     [not found] ` <1417024626-6616-1-git-send-email-james.thomas-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-11-26 17:57   ` [flasher PATCH] Set bootdelay to 0 James Thomas
     [not found]     ` <1417024626-6616-2-git-send-email-james.thomas-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-12-01 18:05       ` Stephen Warren [this message]
     [not found]         ` <547CADF7.8030506-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-12-04 11:50           ` James Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547CADF7.8030506@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=james.thomas-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox