Re: [PATCH v2 2/2] gpio: tegra186: Support multi-socket devices

[Jon Hunter <jonathanh@nvidia.com>]

On 17/02/2026 08:14, Prathamesh Shete wrote:
> On Tegra platforms, multiple SoC instances may be present with each
> defining the same GPIO name. For such devices, this results in
> duplicate GPIO names.
> 
> When the device has a valid NUMA node, prepend the NUMA node ID
> to the GPIO name prefix. The node ID identifies each socket,
> ensuring GPIO line names remain distinct across multiple sockets.
> 
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> ---
> Changes in v2:
>    * Split the v1 patch into two; this one to support multi-socket devices.
> ---
>   drivers/gpio/gpio-tegra186.c | 16 +++++++++++++---
>   1 file changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c
> index f04cc240b5ec..fb26402b6c47 100644
> --- a/drivers/gpio/gpio-tegra186.c
> +++ b/drivers/gpio/gpio-tegra186.c
> @@ -857,7 +857,7 @@ static int tegra186_gpio_probe(struct platform_device *pdev)
>   	struct device_node *np;
>   	struct resource *res;
>   	char **names;
> -	int err;
> +	int node, err;
>   
>   	gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);
>   	if (!gpio)
> @@ -937,13 +937,23 @@ static int tegra186_gpio_probe(struct platform_device *pdev)
>   	if (!names)
>   		return -ENOMEM;
>   
> +	node = dev_to_node(&pdev->dev);
> +
>   	for (i = 0, offset = 0; i < gpio->soc->num_ports; i++) {
>   		const struct tegra_gpio_port *port = &gpio->soc->ports[i];
>   		char *name;
>   
>   		for (j = 0; j < port->pins; j++) {
> -			name = devm_kasprintf(gpio->gpio.parent, GFP_KERNEL, "%sP%s.%02x",
> -					      gpio->soc->prefix ?: "", port->name, j);
> +			if (node >= 0)
> +				name = devm_kasprintf(gpio->gpio.parent, GFP_KERNEL,
> +						      "%d-%sP%s.%02x", node,
> +						      gpio->soc->prefix ?: "",
> +						      port->name, j);
> +			else
> +				name = devm_kasprintf(gpio->gpio.parent, GFP_KERNEL,
> +						      "%sP%s.%02x",
> +						      gpio->soc->prefix ?: "",
> +						      port->name, j);
>   			if (!name)
>   				return -ENOMEM;
>   

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon

-- 
nvpublic