Re: [PATCH nouveau 09/11] drm: export some variable and functions to resue the PM functions

From: Vince Hsu <vinceh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Alexandre Courbot
	<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	"nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	Emil Velikov
	<emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Roy Spliet
	<seven-FA6nBp6kBxZzu6KWmfFNGwC/G2K4zDHf@public.gmane.org>
Subject: Re: [PATCH nouveau 09/11] drm: export some variable and functions to resue the PM functions
Date: Tue, 6 Jan 2015 17:36:43 +0800	[thread overview]
Message-ID: <54ABACAB.4070209@nvidia.com> (raw)
In-Reply-To: <CAAVeFuK-SgUbtHADX4-pXN5_ayzvEd+1KxJOBcRe2tmDfHaLEA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 01/06/2015 03:50 AM, Alexandre Courbot wrote:
> On Mon, Jan 5, 2015 at 4:32 PM, Thierry Reding <thierry.reding@gmail.com> wrote:
>> On Tue, Dec 30, 2014 at 11:18:34AM +0800, Vince Hsu wrote:
>>> Hi Emil,
>>>
>>> On 12/30/2014 10:34 AM, Emil Velikov wrote:
>>>> On 23/12/14 10:40, Vince Hsu wrote:
>>>>> This patch adds some checks in the suspend/resume functions to distinguish
>>>>> the dGPU and mobile GPU and exports some variables/functions so that the
>>>>> nouveau platform device can reuse them.
>>>>>
>>>> Hi Vince,
>>>>
>>>> Afaiu one needs to export a symbol as it's used by another module or
>>>> subsystem. With the follow up two patches you are not doing either one,
>>>> so I'd assume that you can just omit the EXPORT_* changes.
>>> The nouveau platform device driver is built as another module -
>>> nouveau_platform.ko. :)
>> I'd like to hear the opinion of the nouveau people and Alex, but I'd
>> very much prefer if nouveau_platform.o was simply linked into the
>> nouveau.ko module. I don't see any good reason to keep it separate.
> Yep, I agree. The decision to host platform support in a separate
> module looks misleaded if it results in additional exports that we
> would otherwise avoid. IIUC I did this to be able to use the module
> convenience macros to register the platform driver.
>
>> Something like the attached patch (untested) ought to do it.
> This patch alone won't be enough for the reason I mentioned above.
> However, if Vince doesn't mind handling the platform driver
> registration manually in nouveau_drm_init/nouveau_drm_exit, I agree
> this would be the way to go.
I definitely don't mind. :) Will fix in next version based on you guys' 
suggestions.

Thanks,
Vince

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau