From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH] clocksource: tegra: wrap arch/arm-specific sections in CONFIG_ARM Date: Thu, 08 Jan 2015 17:58:01 +0100 Message-ID: <54AEB719.5060103@linaro.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Paul Walmsley , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Gleixner Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Allen Martin , Stephen Warren , Thierry Reding , Alexandre Courbot List-Id: linux-tegra@vger.kernel.org On 12/09/2014 11:07 PM, Paul Walmsley wrote: > > Like several of the other files in drivers/clocksource, > tegra20_timer.c contains code that can only compile when CONFIG_ARM i= s > enabled. This causes obvious problems when trying to compile this > code for NVIDIA ARM64-based SoCs, such as Tegra132. The same timer I= P > blocks exist, so it seems appropriate to provide support for them. > > So until we figure out a better way to partition this code, wrap the > delay_timer and persistent_clock support code with preprocessor tests > for CONFIG_ARM. > > (The delay_timer code should not be needed at all on > ARM64 due to the presence of the ARMv8 architected timer. The > persistent_clock support code could become important once power > management modes are implemented that turn off the CPU complex.) IIUC, the cpuidle driver is not yet ready, right ? If it is the case, this driver is not needed yet, no ? Perhaps you can rework a bit this driver in the meantime to have a=20 better fix than disabling the code with macros ? Otherwise, please try at least to group the code into a minimal set of=20 macros. One comment below. > Signed-off-by: Paul Walmsley > Signed-off-by: Paul Walmsley > Cc: Allen Martin > Cc: Stephen Warren > Cc: Thierry Reding > Cc: Daniel Lezcano > Cc: Thomas Gleixner > Cc: Alexandre Courbot > --- > Applies against next-20141209. > Intended for v3.20. > Boot-tested on Tegra124 Jetson TK1 on next-20141209. > Also boot-tested on Tegra132 Norrin FFD on next-20141209 + extra, > unrelated patches. > > drivers/clocksource/tegra20_timer.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/clocksource/tegra20_timer.c b/drivers/clocksourc= e/tegra20_timer.c > index d2616ef16770..83a8f5c9e139 100644 > --- a/drivers/clocksource/tegra20_timer.c > +++ b/drivers/clocksource/tegra20_timer.c > @@ -29,8 +29,10 @@ > #include > #include > > +#ifdef CONFIG_ARM > #include > #include Is smp_twd.h really needed ? > +#endif [ ... ] Thanks -- Daniel --=20 Linaro.org =E2=94=82 Open source software fo= r ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog