Re: [PATCH] drm: merge nouveau_platform.ko into nouveau.ko

[Vince Hsu <vinceh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]

On 01/15/2015 02:43 PM, Alexandre Courbot wrote:
> On Thu, Jan 15, 2015 at 3:39 PM, Ben Skeggs <skeggsb@gmail.com> wrote:
>> On Thu, Jan 15, 2015 at 4:29 PM, Alexandre Courbot <acourbot@nvidia.com> wrote:
>>> Having the two modules separated causes various unneeded complications,
>>> including having to export symbols accessed between the modules. Make
>>> things simpler by compiling platform device support into nouveau.ko.
>>> Platform device support remains optional and is only compiled on Tegra.
>>>
>>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>>> ---
>>> Vince, with this you won't have to export new functions for PM. I ended
>>> up writing it myself because I hit the same issue (nv_device() would now
>>> need to be exported on Ben's master branch).
>>>
>>> Be careful that when compiling against a kernel, CONFIG_NOUVEAU_PLATFORM_DRIVER
>>> now *must* be equal to 'y'. It is 'm' currently, so you will need to change it
>>> from tristate to bool in the kernel's Kconfig. For this reason it might be good
>>> to get this patch into -next quickly.
>> I've got a huge chunk of churn (finally finished the "rename to nvidia
>> names for stuff" thing) pending too which I want to get to Dave (ASAP,
>> separately from my other pending work) to avoid having to keep fixing
>> conflicts in the meantime :)
>>
>> So, if you guys both agree on the patch, I'll send it along early with those.
> That would be just perfect.
>
> Vince, do you have anything against this patch?
Of course not. I just tested it and it worked as good as expected. 
Thanks for sending this.

Vince


_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau