From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vince Hsu Subject: Re: [RFC PATCH 2/9] memory: tegra: add mc flush support Date: Tue, 3 Mar 2015 16:09:10 +0800 Message-ID: <54F56C26.1020202@nvidia.com> References: <1421216372-8025-1-git-send-email-vinceh@nvidia.com> <1421216372-8025-3-git-send-email-vinceh@nvidia.com> <54F42549.5040202@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexandre Courbot Cc: Thierry Reding , Peter De Schrijver , Stephen Warren , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On 03/03/2015 04:03 PM, Alexandre Courbot wrote: > On Mon, Mar 2, 2015 at 6:29 PM, Alexandre Courbot wrote: >>>> These functions are identical, excepted for the callback they are >>>> invoking. Could you merge the common part into a function that returns >>>> the right client to call the callback on, or ERR_PTR(-EINVAL) in case >>>> of failure? >>> I couldn't think of a clever way to do this. Any ideas? :) >> How about something like this (warning: might now be that great, untested): >> >> /* Have this in your .h and use it in your tegra_mc_ops struct */ >> typedef int (*mc_op)(struct tegra_mc *mc, >> const struct tegra_mc_hotreset *hotreset) > This type should be named tegra_mc_op, since the header that defines > it is in include/linux. Can we just leave it in this C file? I see no reason to place it in some other header file. :) Thanks, Vince