From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Daniel Stone <daniels-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Cc: Tomeu Vizoso
<tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Andrew Bresticker
<abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Dylan Reid <dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: Re: [pinmux scripts PATCH] Update Nyan-Big pinmux from ChromeOS
Date: Fri, 06 Mar 2015 13:46:41 -0700 [thread overview]
Message-ID: <54FA1231.9000709@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ0Uir9PZ1RWKCua0q0R6NMgGotqR7+jAkc_aJd1xTx4ew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 03/06/2015 01:42 PM, Simon Glass wrote:
> Hi Stephen,
>
> On 6 March 2015 at 13:31, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
>> On 03/06/2015 01:07 PM, Daniel Stone wrote:
>>>
>>> Update the pinmux, in particular USB and SD/MMC pin configuration, from
>>> downstream ChromeOS kernel. Fixes external USB falling off completely
>>> during heavy eMMC activity.
>>
>>
>> Simon (and Tomeu),
>>
>> Can you comment on this change? If the data currently in
>> tegra-pinmux-scripts is wrong, where did it come from if not the ChromeOS
>> kernel?
>
> Sorry, I have no direct knowledge.
Oh, I see the answer in the patch description:
> commit 4a5373e4bd6477addd3764e25989f74d34eba8c6
> Author: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Date: Tue Feb 3 11:29:03 2015 +0100
>
> Add support for Nyan-big
>
> Add support for Tegra124 Nyan-big. Pinmux is based on norrin with a single
> change for the reset GPIO.
The need for Daniel's patch seems like a good reason not to base one
board's pinmux on another board, assuming they're identical...
Daniel, have you confirmed that 100% of the data in your patch matches
that used by the ChromeOS kernel, such that there shouldn't be any more
fixes needed down the line?
next prev parent reply other threads:[~2015-03-06 20:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 20:07 [PATCH] Update Nyan-Big pinmux from ChromeOS Daniel Stone
[not found] ` <1425672435-19031-1-git-send-email-daniels-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2015-03-06 20:31 ` [pinmux scripts PATCH] " Stephen Warren
[not found] ` <54FA0EBB.3080208-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-03-06 20:42 ` Simon Glass
[not found] ` <CAPnjgZ0Uir9PZ1RWKCua0q0R6NMgGotqR7+jAkc_aJd1xTx4ew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-06 20:46 ` Stephen Warren [this message]
2015-03-09 15:39 ` Daniel Stone
[not found] ` <1425915411.12254.0@mail.collabora.com>
[not found] ` <1425915411.12254.0-u1PCbA9B4pYthqhpMEQ9fNBPR1lH4CV8@public.gmane.org>
2015-03-09 16:23 ` Stephen Warren
2015-03-09 16:40 ` Daniel Stone
[not found] ` <loom.20150309T173610-946-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2015-03-10 16:26 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FA1231.9000709@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=daniels-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox