linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Jimmy Zhang <jimmzhang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [cbootimage PATCH v3 0/3] Add support for Tegra210
Date: Mon, 23 Mar 2015 15:19:36 -0600	[thread overview]
Message-ID: <55108368.8000606@wwwdotorg.org> (raw)
In-Reply-To: <20150323211336.GB30637-+E7KM1FDEuP5BGCcOMqoLIH6Mc4MB0Vx@public.gmane.org>

On 03/23/2015 03:13 PM, Thierry Reding wrote:
> On Mon, Mar 23, 2015 at 02:26:10PM -0600, Stephen Warren wrote:
>> On 03/20/2015 06:20 PM, Jimmy Zhang wrote:
>>> Four t210 specific supporting files are added under src/t210 diretory.
>>> Comparing T210 bct to T132 bct, the main changes include the size increased
>>> to 10240 from 8704. The number of boot devices that can be specified in bct
>>> is reduced from 4 to 1. And many new fileds are added to nvboot_sdram_params.
>>>
>>> v1: Initial changes
>>> v2: Fix some minor issues found in v1
>>>      Removed files src/t210/nvboot_config.h and src/t210/sdram_param.h
>>>              that were added unintentionally in v1.
>>> v3: Remove "deprecated" from help -t option help text.
>>
>> I think this version looks fine. Barring any objections, I'll apply it Tue
>> my time sometime.
>
> I wasn't able to successfully dump a BCT using this series. I'm not sure
> if that's actually caused by a bad BCT or by the patches not being
> correct. Do we have canonical BCT sources somewhere for something like
> Foster?
>
> The problem I'm seeing is that bct_dump reports that the BCT contains 0
> SDRAM sets, whereas I'm pretty sure I've used the same BCT to bootstrap
> a device with tegrarcm, so it's got to have valid SDRAM sets defined. I
> can dig deeper, but it'd be good to have a reference BCT source and
> image to verify that converting to BCT and back to source actually is an
> idempotent operation.

OK, I'll hold off applying this until you've been able to use it 
successfully.

I did check that the patches compiled, and that tegra-uboot-flasher was 
able to build flash images for all existing boards, but didn't attempt 
to use the new SoC support.

  parent reply	other threads:[~2015-03-23 21:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-21  0:20 [cbootimage PATCH v3 0/3] Add support for Tegra210 Jimmy Zhang
     [not found] ` <1426897221-20307-1-git-send-email-jimmzhang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-03-21  0:20   ` [cbootimage PATCH v3 1/3] " Jimmy Zhang
2015-03-21  0:20   ` [cbootimage PATCH v3 2/3] Remove misleading message "deprecated" Jimmy Zhang
2015-03-21  0:20   ` [cbootimage PATCH v3 3/3] Bump to version 1.5 Jimmy Zhang
2015-03-23 20:26   ` [cbootimage PATCH v3 0/3] Add support for Tegra210 Stephen Warren
     [not found]     ` <551076E2.9000408-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-03-23 21:13       ` Thierry Reding
     [not found]         ` <20150323211336.GB30637-+E7KM1FDEuP5BGCcOMqoLIH6Mc4MB0Vx@public.gmane.org>
2015-03-23 21:19           ` Stephen Warren [this message]
     [not found]             ` <55108368.8000606-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-03-23 21:25               ` Jimmy Zhang
     [not found]                 ` <eff14e98c9f44e0c89c0c88b64ed3f12-wO81nVYWzR7YuxH7O460wFaTQe2KTcn/@public.gmane.org>
2015-03-23 21:32                   ` Jimmy Zhang
     [not found]                     ` <c9ac7389b5bf488d8b8f15523f1820b0-wO81nVYWzR7YuxH7O460wFaTQe2KTcn/@public.gmane.org>
2015-03-23 21:38                       ` Jimmy Zhang
2015-03-25  8:33   ` Thierry Reding
     [not found]     ` <20150325083259.GA3794-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2015-03-25 14:23       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55108368.8000606@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=jimmzhang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).