From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] irqchip: tegra: fix wrong data being passed as the irqdomain chip data Date: Wed, 13 May 2015 16:18:12 -0600 Message-ID: <5553CDA4.6000905@wwwdotorg.org> References: <1431202014-3136-1-git-send-email-dev@lynxeye.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1431202014-3136-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lucas Stach Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Thierry Reding , Alexandre Courbot , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 05/09/2015 02:06 PM, Lucas Stach wrote: > The irq chip functions use the irq chipdata directly as the base register > address of the controller, so this should be passed in instead of a pointer > to the array address holding the base address. > > This fixes Tegra20 CPUidle as now the un-/masking of IRQs at the LIC level > works again, but more importantly it fixes the resulting memory corruption. Tested-by: Stephen Warren Tested on NVIDIA Seaboard (which is affected by the bug in the default configuration/DT) with the patch applied on to of 4.1-rc3.