[pinmux scripts PATCH] board-to-kernel-dt: don't generate outer state node

[pinmux scripts PATCH] board-to-kernel-dt: don't generate outer state node

[Stephen Warren]

From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

The important thing for board-to-kernel-dt to generate is the content of
the pinmux "state" node in DT. The name and label of the node that
contains this information is essentially irrelevant. Since this
irrelevant name and label varies between boards in existing DTs, update
board-to-kernel-dt so it doesn't generate it. This makes it obvious that
the name and label shouldn't be modified when importing new versions of
board-to-kernel-dt's output.

Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 board-to-kernel-dt.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/board-to-kernel-dt.py b/board-to-kernel-dt.py
index 273f74125fa6..55e556cea98b 100755
--- a/board-to-kernel-dt.py
+++ b/board-to-kernel-dt.py
@@ -44,8 +44,6 @@ def mapper_pull(val):
 def mapper_bool(val):
     return 'TEGRA_PIN_' + {False: 'DISABLE', True: 'ENABLE'}[val]
 
-print('		state_default: pinmux {')
-
 for pincfg in board.pincfgs_by_num():
     print('			' + pincfg.fullname + ' {')
     print('				nvidia,pins = "' + pincfg.fullname + '";')
@@ -70,6 +68,4 @@ for cfg in board.mipipadctrlcfgs_by_num():
     print('				nvidia,function = "' + cfg.mux + '";')
     print('			};')
 
-print('		};')
-
 board.warn_about_unconfigured_pins()
-- 
1.9.1

Re: [pinmux scripts PATCH] board-to-kernel-dt: don't generate outer state node

[Simon Glass]

On 14 May 2015 at 08:20, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> The important thing for board-to-kernel-dt to generate is the content of
> the pinmux "state" node in DT. The name and label of the node that
> contains this information is essentially irrelevant. Since this
> irrelevant name and label varies between boards in existing DTs, update
> board-to-kernel-dt so it doesn't generate it. This makes it obvious that
> the name and label shouldn't be modified when importing new versions of
> board-to-kernel-dt's output.
>
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  board-to-kernel-dt.py | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

I don't suppose this stuff can go in a separate .dtsi include?

>
> diff --git a/board-to-kernel-dt.py b/board-to-kernel-dt.py
> index 273f74125fa6..55e556cea98b 100755
> --- a/board-to-kernel-dt.py
> +++ b/board-to-kernel-dt.py
> @@ -44,8 +44,6 @@ def mapper_pull(val):
>  def mapper_bool(val):
>      return 'TEGRA_PIN_' + {False: 'DISABLE', True: 'ENABLE'}[val]
>
> -print('                state_default: pinmux {')
> -
>  for pincfg in board.pincfgs_by_num():
>      print('                    ' + pincfg.fullname + ' {')
>      print('                            nvidia,pins = "' + pincfg.fullname + '";')
> @@ -70,6 +68,4 @@ for cfg in board.mipipadctrlcfgs_by_num():
>      print('                            nvidia,function = "' + cfg.mux + '";')
>      print('                    };')
>
> -print('                };')
> -
>  board.warn_about_unconfigured_pins()
> --
> 1.9.1
>

Regards,
Simon

Re: [pinmux scripts PATCH] board-to-kernel-dt: don't generate outer state node

[Stephen Warren]

On 05/14/2015 08:29 AM, Simon Glass wrote:
> On 14 May 2015 at 08:20, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>
>> The important thing for board-to-kernel-dt to generate is the content of
>> the pinmux "state" node in DT. The name and label of the node that
>> contains this information is essentially irrelevant. Since this
>> irrelevant name and label varies between boards in existing DTs, update
>> board-to-kernel-dt so it doesn't generate it. This makes it obvious that
>> the name and label shouldn't be modified when importing new versions of
>> board-to-kernel-dt's output.
>>
>> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> ---
>>   board-to-kernel-dt.py | 4 ----
>>   1 file changed, 4 deletions(-)
>
> Reviewed-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>
> I don't suppose this stuff can go in a separate .dtsi include?

That might make sense. I guess send a patch and see if Thierry takes it:-)

Re: [pinmux scripts PATCH] board-to-kernel-dt: don't generate outer state node

[Stephen Warren]

On 05/14/2015 08:29 AM, Simon Glass wrote:
> On 14 May 2015 at 08:20, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>
>> The important thing for board-to-kernel-dt to generate is the content of
>> the pinmux "state" node in DT. The name and label of the node that
>> contains this information is essentially irrelevant. Since this
>> irrelevant name and label varies between boards in existing DTs, update
>> board-to-kernel-dt so it doesn't generate it. This makes it obvious that
>> the name and label shouldn't be modified when importing new versions of
>> board-to-kernel-dt's output.
>>
>> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> ---
>>   board-to-kernel-dt.py | 4 ----
>>   1 file changed, 4 deletions(-)
>
> Reviewed-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

I've applied this.