From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH] spi: tegra20-slink: add missing pm_runtime_put Date: Fri, 5 Jun 2020 07:02:39 +0100 Message-ID: <555a3d93-ea24-a633-2ea4-904fcd8fd8a2@nvidia.com> References: <20200602052602.91374-1-navid.emamdoost@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200602052602.91374-1-navid.emamdoost-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Navid Emamdoost , Laxman Dewangan , Mark Brown , Thierry Reding , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: emamd001-OJFnDUYgAso@public.gmane.org, wu000273-OJFnDUYgAso@public.gmane.org, kjlu-OJFnDUYgAso@public.gmane.org, smccaman-OJFnDUYgAso@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 02/06/2020 06:26, Navid Emamdoost wrote: > Call to pm_runtime_get_sync increments counter even in case of > failure leading to incorrect ref count. > Call pm_runtime_put if pm_runtime_get_sync fails. > > Signed-off-by: Navid Emamdoost > --- > drivers/spi/spi-tegra20-slink.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c > index 7f4d932dade7..0675b36d647b 100644 > --- a/drivers/spi/spi-tegra20-slink.c > +++ b/drivers/spi/spi-tegra20-slink.c > @@ -1192,6 +1192,7 @@ static int tegra_slink_resume(struct device *dev) > ret = pm_runtime_get_sync(dev); > if (ret < 0) { > dev_err(dev, "pm runtime failed, e = %d\n", ret); > + pm_runtime_put(dev); > return ret; > } > tegra_slink_writel(tspi, tspi->command_reg, SLINK_COMMAND); Please squash this patch with the other 2 that are fixing the same issues in the same driver. Jon -- nvpublic