* re: clk: tegra: Add closed loop support for the DFLL
@ 2015-05-23 17:15 Dan Carpenter
2015-05-23 18:55 ` Mikko Perttunen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-05-23 17:15 UTC (permalink / raw)
To: ttynkkynen-DDmLM1+adcrQT0dZR+AlfA; +Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA
Hello Tuomas Tynkkynen,
The patch 435874b0fdf4: "clk: tegra: Add closed loop support for the
DFLL" from May 13, 2015, leads to the following static checker
warning:
drivers/clk/tegra/clk-dfll.c:1448 dfll_build_i2c_lut()
warn: unsigned 'td->i2c_lut[0]' is never less than zero.
drivers/clk/tegra/clk-dfll.c
1446 v = td->soc->min_millivolts * 1000;
1447 td->i2c_lut[0] = find_vdd_map_entry_exact(td, v);
1448 if (td->i2c_lut[0] < 0)
^^^^^^^^^^^^^^^^^^
Never true.
1449 goto out;
1450
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: clk: tegra: Add closed loop support for the DFLL
2015-05-23 17:15 clk: tegra: Add closed loop support for the DFLL Dan Carpenter
@ 2015-05-23 18:55 ` Mikko Perttunen
0 siblings, 0 replies; 2+ messages in thread
From: Mikko Perttunen @ 2015-05-23 18:55 UTC (permalink / raw)
To: Dan Carpenter, ttynkkynen-DDmLM1+adcrQT0dZR+AlfA
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA
On 05/23/2015 08:15 PM, Dan Carpenter wrote:
> Hello Tuomas Tynkkynen,
>
> The patch 435874b0fdf4: "clk: tegra: Add closed loop support for the
> DFLL" from May 13, 2015, leads to the following static checker
> warning:
>
> drivers/clk/tegra/clk-dfll.c:1448 dfll_build_i2c_lut()
> warn: unsigned 'td->i2c_lut[0]' is never less than zero.
>
> drivers/clk/tegra/clk-dfll.c
> 1446 v = td->soc->min_millivolts * 1000;
> 1447 td->i2c_lut[0] = find_vdd_map_entry_exact(td, v);
> 1448 if (td->i2c_lut[0] < 0)
> ^^^^^^^^^^^^^^^^^^
> Never true.
>
> 1449 goto out;
> 1450
>
> regards,
> dan carpenter
Thanks for checking; for now, this shouldn't cause any problems. I will
post a patch on monday.
Cheers,
Mikko.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-23 18:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-23 17:15 clk: tegra: Add closed loop support for the DFLL Dan Carpenter
2015-05-23 18:55 ` Mikko Perttunen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).