* [PATCH] ARM: tegra: paz00: set gpiod_lookup table conn_id's
@ 2015-06-28 19:34 Dmitry Osipenko
[not found] ` <1435520160-16862-1-git-send-email-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Osipenko @ 2015-06-28 19:34 UTC (permalink / raw)
To: Thierry Reding, Stephen Warren, Marc Dietrich, Alexandre Courbot
Cc: Mika Westerberg, Rafael J. Wysocki, Dmitry Osipenko,
stable-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
for ACPI") removed possibility to request GPIO by table index for non-ACPI
platforms without changing it users. As result "shutdown" GPIO request
will fail if request for "reset" GPIO succeeded or "reset" will be
requested instead of "shutdown" if "reset" wasn't defined. Fix it by
setting conn_id's in gpiod_lookup_table.
Signed-off-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Fixes: 72daceb (net: rfkill: gpio: Add default GPIO driver mappings for ACPI)
Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # v3.19+
---
arch/arm/mach-tegra/board-paz00.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
index fbe74c6..67024f3 100644
--- a/arch/arm/mach-tegra/board-paz00.c
+++ b/arch/arm/mach-tegra/board-paz00.c
@@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {
static struct gpiod_lookup_table wifi_gpio_lookup = {
.dev_id = "rfkill_gpio",
.table = {
- GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0),
- GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0),
+ GPIO_LOOKUP_IDX("tegra-gpio", 25, "reset", 0, 0),
+ GPIO_LOOKUP_IDX("tegra-gpio", 85, "shutdown", 1, 0),
{ },
},
};
--
2.4.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: tegra: paz00: set gpiod_lookup table conn_id's
[not found] ` <1435520160-16862-1-git-send-email-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2015-06-30 13:42 ` Alexandre Courbot
[not found] ` <CAAVeFuKcaz1C9OV26+8A+LypScqDcufR+X99KDJwVui39Nq7xA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Courbot @ 2015-06-30 13:42 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Thierry Reding, Stephen Warren, Marc Dietrich, Mika Westerberg,
Rafael J. Wysocki, Stable,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux Kernel Mailing List
On Mon, Jun 29, 2015 at 4:34 AM, Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
> for ACPI") removed possibility to request GPIO by table index for non-ACPI
> platforms without changing it users. As result "shutdown" GPIO request
> will fail if request for "reset" GPIO succeeded or "reset" will be
> requested instead of "shutdown" if "reset" wasn't defined. Fix it by
> setting conn_id's in gpiod_lookup_table.
Yep, and using con_ids is a good idea anyway.
Acked-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Signed-off-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Fixes: 72daceb (net: rfkill: gpio: Add default GPIO driver mappings for ACPI)
> Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # v3.19+
> ---
> arch/arm/mach-tegra/board-paz00.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
> index fbe74c6..67024f3 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {
> static struct gpiod_lookup_table wifi_gpio_lookup = {
> .dev_id = "rfkill_gpio",
> .table = {
> - GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0),
> - GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0),
> + GPIO_LOOKUP_IDX("tegra-gpio", 25, "reset", 0, 0),
> + GPIO_LOOKUP_IDX("tegra-gpio", 85, "shutdown", 1, 0),
> { },
> },
> };
> --
> 2.4.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: tegra: paz00: set gpiod_lookup table conn_id's
[not found] ` <CAAVeFuKcaz1C9OV26+8A+LypScqDcufR+X99KDJwVui39Nq7xA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2015-06-30 13:56 ` Dmitry Osipenko
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Osipenko @ 2015-06-30 13:56 UTC (permalink / raw)
To: Alexandre Courbot
Cc: Thierry Reding, Stephen Warren, Marc Dietrich, Mika Westerberg,
Rafael J. Wysocki, Stable,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux Kernel Mailing List
30.06.2015 16:42, Alexandre Courbot пишет:
> On Mon, Jun 29, 2015 at 4:34 AM, Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
>> for ACPI") removed possibility to request GPIO by table index for non-ACPI
>> platforms without changing it users. As result "shutdown" GPIO request
>> will fail if request for "reset" GPIO succeeded or "reset" will be
>> requested instead of "shutdown" if "reset" wasn't defined. Fix it by
>> setting conn_id's in gpiod_lookup_table.
>
> Yep, and using con_ids is a good idea anyway.
>
> Acked-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
After discussion on irc, turned out that patch missed
s/GPIO_LOOKUP_IDX/GPIO_LOOKUP. I'll send V2.
And s/conn_id/con_id typo started to annoy me...
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-30 13:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-28 19:34 [PATCH] ARM: tegra: paz00: set gpiod_lookup table conn_id's Dmitry Osipenko
[not found] ` <1435520160-16862-1-git-send-email-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-06-30 13:42 ` Alexandre Courbot
[not found] ` <CAAVeFuKcaz1C9OV26+8A+LypScqDcufR+X99KDJwVui39Nq7xA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-30 13:56 ` Dmitry Osipenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).