Re: [PATCH] drivers: staging: nvec: remove bogus reset command for PS/2 interface

[Marc Dietrich <marvin24@gmx.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1389 bytes --]

Hi Paul,

thanks for finding the issue!

Am Donnerstag, 27. Oktober 2016, 16:55:14 CEST schrieb Paul Fertser:
> This command was sent behind serio's back and the answer to it was
> confusing atkbd probe function which lead to the elantech touchpad
> getting detected as a keyboard.
> 
> To prevent this from happening just let every party do its part of the
> job.
> 
> Signed-off-by: Paul Fertser <fercerpav@gmail.com>

Please send a complete patch in a new thread (or titled with V2) with the 
serio type change included.

Thanks,

Marc

> ---
>  drivers/staging/nvec/nvec_ps2.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/nvec/nvec_ps2.c
> b/drivers/staging/nvec/nvec_ps2.c index c83eeb4..910e87b 100644
> --- a/drivers/staging/nvec/nvec_ps2.c
> +++ b/drivers/staging/nvec/nvec_ps2.c
> @@ -106,7 +106,6 @@ static int nvec_mouse_probe(struct platform_device
> *pdev) {
>  	struct nvec_chip *nvec = dev_get_drvdata(pdev->dev.parent);
>  	struct serio *ser_dev;
> -	char mouse_reset[] = { NVEC_PS2, SEND_COMMAND, PSMOUSE_RST, 3 };
> 
>  	ser_dev = devm_kzalloc(&pdev->dev, sizeof(struct serio), GFP_KERNEL);
>  	if (!ser_dev)
> @@ -127,9 +126,6 @@ static int nvec_mouse_probe(struct platform_device
> *pdev)
> 
>  	serio_register_port(ser_dev);
> 
> -	/* mouse reset */
> -	nvec_write_async(nvec, mouse_reset, sizeof(mouse_reset));
> -
>  	return 0;
>  }


[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[-- Attachment #2: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel