From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikko Perttunen Subject: Re: [PATCH] soc/tegra: pmc: Avoid usage of uninitialized variable Date: Thu, 9 Jul 2015 11:03:40 +0300 Message-ID: <559E2ADC.9040902@nvidia.com> References: <1436428795-32000-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1436428795-32000-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: Mikko Perttunen , Nicolas Chauvet , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org Thanks for the fix; sorry for the typo or whatever you can call it :) This should also go into 4.0 and 4.1. Cheers, Mikko. On 07/09/2015 10:59 AM, Thierry Reding wrote: > From: Thierry Reding > > Make sure to only drop the reference to the OF node after it's been > successfully obtained. > > Signed-off-by: Thierry Reding > --- > drivers/soc/tegra/pmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c > index 1878d4da715d..6b0df8154fa4 100644 > --- a/drivers/soc/tegra/pmc.c > +++ b/drivers/soc/tegra/pmc.c > @@ -1043,12 +1043,12 @@ void tegra_pmc_init_tsense_reset(struct tegra_pmc *pmc) > u32 value, checksum; > > if (!pmc->soc->has_tsense_reset) > - goto out; > + return; > > np = of_find_node_by_name(pmc->dev->of_node, "i2c-thermtrip"); > if (!np) { > dev_warn(dev, "i2c-thermtrip node not found, %s.\n", disabled); > - goto out; > + return; > } > > if (of_property_read_u32(np, "nvidia,i2c-controller-id", &ctrl_id)) { >