From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v2] ARM: tegra: paz00: use con_id's to refer GPIO's in gpiod_lookup table Date: Mon, 7 Sep 2015 12:21:37 +0300 Message-ID: <55ED5721.80508@gmail.com> References: <1435673759-11996-1-git-send-email-digetx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1435673759-11996-1-git-send-email-digetx@gmail.com> Sender: stable-owner@vger.kernel.org To: Stephen Warren , Thierry Reding , Alexandre Courbot , Marc Dietrich Cc: Mika Westerberg , "Rafael J. Wysocki" , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org 30.06.2015 17:15, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mapp= ings > for ACPI") removed possibility to request GPIO by table index for non= -ACPI > platforms without changing it users. As result "shutdown" GPIO reques= t > will fail if request for "reset" GPIO succeeded or "reset" will be > requested instead of "shutdown" if "reset" wasn't defined. Fix it by > making gpiod_lookup_table use con_id's instead of indexes. > > Signed-off-by: Dmitry Osipenko > Fixes: 72daceb (net: rfkill: gpio: Add default GPIO driver mappings f= or ACPI) > Cc: # v3.19+ > Acked-by: Alexandre Courbot > --- > > v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't b= e requested > > arch/arm/mach-tegra/board-paz00.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/= board-paz00.c > index fbe74c6..49d1110 100644 > --- a/arch/arm/mach-tegra/board-paz00.c > +++ b/arch/arm/mach-tegra/board-paz00.c > @@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device =3D= { > static struct gpiod_lookup_table wifi_gpio_lookup =3D { > .dev_id =3D "rfkill_gpio", > .table =3D { > - GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0), > - GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0), > + GPIO_LOOKUP("tegra-gpio", 25, "reset", 0), > + GPIO_LOOKUP("tegra-gpio", 85, "shutdown", 0), > { }, > }, > }; > Ping --=20 Dmitry