public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Akhil R <akhilrajeev@nvidia.com>, Vinod Koul <vkoul@kernel.org>,
	Frank Li <Frank.Li@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thierry Reding <thierry.reding@kernel.org>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/9] dt-bindings: dma: nvidia,tegra186-gpc-dma: Make reset optional
Date: Tue, 24 Mar 2026 10:47:45 +0000	[thread overview]
Message-ID: <55dc0957-fdc5-4821-891d-76df677ca94f@nvidia.com> (raw)
In-Reply-To: <20260316171823.61800-3-akhilrajeev@nvidia.com>



On 16/03/2026 17:18, Akhil R wrote:
> On Tegra264, GPCDMA reset control is not exposed to Linux and is handled
> by the boot firmware.
> 
> Although the reset was not exposed in Tegra234 as well, the firmware
> supported a dummy reset which just returns success on reset without doing
> an actual reset. This is also not supported in Tegra264. Therefore mark
> 'reset' and 'reset-names' properties as required only for devices prior
> to Tegra264.
> 
> This also necessitates that the Tegra264 compatible be standalone and
> cannot have the fallback compatible of Tegra186. Since there is no
> functional impact, we keep reset as required for Tegra234 to avoid
> breaking the ABI.
> 

This is a fix for Tegra264 and so having a fixes tag here seems appropriate.

> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
>   .../bindings/dma/nvidia,tegra186-gpc-dma.yaml | 25 +++++++++++++------
>   1 file changed, 18 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> index b5d8fd0b281d..b849d4cc2901 100644
> --- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> @@ -16,16 +16,14 @@ maintainers:
>     - Rajesh Gumasta <rgumasta@nvidia.com>
>     - Akhil R <akhilrajeev@nvidia.com>
>   
> -allOf:
> -  - $ref: dma-controller.yaml#
> -
>   properties:
>     compatible:
>       oneOf:
> -      - const: nvidia,tegra186-gpcdma
> +      - enum:
> +          - nvidia,tegra264-gpcdma
> +          - nvidia,tegra186-gpcdma
>         - items:
>             - enum:
> -              - nvidia,tegra264-gpcdma
>                 - nvidia,tegra234-gpcdma
>                 - nvidia,tegra194-gpcdma
>             - const: nvidia,tegra186-gpcdma
> @@ -69,12 +67,25 @@ required:
>     - compatible
>     - reg
>     - interrupts
> -  - resets
> -  - reset-names
>     - "#dma-cells"
>     - iommus
>     - dma-channel-mask
>   
> +allOf:
> +  - $ref: dma-controller.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - nvidia,tegra186-gpcdma
> +              - nvidia,tegra194-gpcdma
> +              - nvidia,tegra234-gpcdma
> +    then:
> +      required:
> +        - resets
> +        - reset-names
> +
>   additionalProperties: false
>   
>   examples:

-- 
nvpublic


  reply	other threads:[~2026-03-24 10:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 17:18 [PATCH v3 0/9] Add GPCDMA support in Tegra264 Akhil R
2026-03-16 17:18 ` [PATCH v3 1/9] dt-bindings: dma: nvidia,tegra186-gpc-dma: Add iommu-map property Akhil R
2026-03-25 16:35   ` Rob Herring (Arm)
2026-03-16 17:18 ` [PATCH v3 2/9] dt-bindings: dma: nvidia,tegra186-gpc-dma: Make reset optional Akhil R
2026-03-24 10:47   ` Jon Hunter [this message]
2026-03-25 16:37   ` Rob Herring (Arm)
2026-03-16 17:18 ` [PATCH v3 3/9] dmaengine: tegra: Make reset control optional Akhil R
2026-03-16 17:18 ` [PATCH v3 4/9] dmaengine: tegra: Use struct for register offsets Akhil R
2026-03-16 17:18 ` [PATCH v3 5/9] dmaengine: tegra: Support address width > 39 bits Akhil R
2026-03-16 17:18 ` [PATCH v3 6/9] dmaengine: tegra: Use managed DMA controller registration Akhil R
2026-03-16 17:18 ` [PATCH v3 7/9] dmaengine: tegra: Use iommu-map for stream ID Akhil R
2026-03-16 17:18 ` [PATCH v3 8/9] dmaengine: tegra: Add Tegra264 support Akhil R
2026-03-16 17:18 ` [PATCH v3 9/9] arm64: tegra: Enable GPCDMA and add iommu-map in Tegra264 Akhil R
2026-03-24 10:46   ` Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55dc0957-fdc5-4821-891d-76df677ca94f@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=Frank.Li@kernel.org \
    --cc=akhilrajeev@nvidia.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=thierry.reding@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox