From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Tom Warren <TWarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org"
<u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org>,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"tomcwarren3959-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<tomcwarren3959-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org"
<jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>,
"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"pawel.moll-5wv7dgnIgG8@public.gmane.org"
<pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"mark.rutland-5wv7dgnIgG8@public.gmane.org"
<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org"
<galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Alex Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v3] Tegra: DT: add device tree binding doc for QSPI
Date: Mon, 26 Oct 2015 15:49:30 -0600 [thread overview]
Message-ID: <562E9FEA.1080705@wwwdotorg.org> (raw)
In-Reply-To: <731fc53aa2d24edc93c2af43a7711657-wO81nVYWzR66sJks/06JalaTQe2KTcn/@public.gmane.org>
On 10/26/2015 03:36 PM, Tom Warren wrote:
> Stephen Warren wrote at Monday, October 26, 2015 2:04 PM:
>> On 10/26/2015 02:34 PM, Tom Warren wrote:
>>> This patch adds the device tree binding doc for the Tegra QSPI
>>> controller on Tegra210.
>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt
>>> b/Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt
>>
>>> +- clock-names : Must include the following entries:
>>> + - qspi
>>> +- resets : Must contain an entry for each entry in reset-names.
>>> + See ../reset/reset.txt for details.
>>> +- reset-names : Must include the following entries:
>>> + - qspi
>>> +- clocks : Must contain an entry for each entry in clock-names.
>>> + See ../clocks/clock-bindings.txt for details.
>>
>> Let's keep clocks and clock-names next to each-other in the doc. I don't know
>> why they aren't in the eixsting Tegra SPI doc.
>
> OK. I assume 'clock-names', then 'clocks' since 'clocks' references clock-names.
That sounds correct.
>> With this issue fixed, this patch looks good to me.
>>
>> Note: I don't see the devicetree mailing list in the CC list. You should probably
>> replace the U-Boot mailing list with it.
>
> I thought I had it, but may have dropped it. What exactly is the URL of the devicetree mailing list? devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org? or devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org?
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
(See the "OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" in
"MAINTAINERS", or the output of ./scripts/get_maintainers.pl)
prev parent reply other threads:[~2015-10-26 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 20:34 [PATCH v3] Tegra: DT: add device tree binding doc for QSPI Tom Warren
[not found] ` <1445891676-3262-1-git-send-email-twarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-10-26 21:04 ` Stephen Warren
[not found] ` <562E954B.5070604-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-10-26 21:36 ` Tom Warren
[not found] ` <731fc53aa2d24edc93c2af43a7711657-wO81nVYWzR66sJks/06JalaTQe2KTcn/@public.gmane.org>
2015-10-26 21:49 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562E9FEA.1080705@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=TWarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=tomcwarren3959-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).