From: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V3 2/2] dmaengine: tegra-adma: Add support for Tegra210 ADMA
Date: Tue, 27 Oct 2015 09:24:01 +0000 [thread overview]
Message-ID: <562F42B1.30102@nvidia.com> (raw)
In-Reply-To: <20151027021008.GD11691-bQVUxfxUtC13uc1i7fC1zK2pdiUAq4bhAL8bYrjMMd8@public.gmane.org>
On 27/10/15 02:10, Vinod Koul wrote:
> On Fri, Oct 16, 2015 at 08:35:19AM +0100, Jon Hunter wrote:
>> +static inline void tdma_ch_write(struct tegra_adma_chan *tdc,
>> + u32 reg, u32 val)
>
> Coding style issue here
Yes will correct.
>> +static int tegra_adma_alloc_chan_resources(struct dma_chan *dc)
>> +{
>> + struct tegra_adma_chan *tdc = to_tegra_adma_chan(dc);
>> + int ret;
>> +
>> + ret = pm_runtime_get_sync(tdc2dev(tdc));
>> + if (ret)
>> + return ret;
>
> pm_runtime_get_sync() return postive values on success too, so this can
> fail. This check should be for less than zero case
I stumbled upon that recently and will also fix up.
Cheers
Jon
next prev parent reply other threads:[~2015-10-27 9:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 7:35 [PATCH V3 0/2] Add support for Tegra210 ADMA Jon Hunter
2015-10-16 7:35 ` [PATCH V3 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Jon Hunter
[not found] ` <1444980919-20331-2-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-10-16 16:09 ` Stephen Warren
[not found] ` <56212139.4080101-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-10-19 11:22 ` Jon Hunter
[not found] ` <5624D28B.70803-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-10-19 16:33 ` Stephen Warren
[not found] ` <56251B56.70007-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-10-20 8:54 ` Jon Hunter
2015-10-16 7:35 ` [PATCH V3 2/2] dmaengine: tegra-adma: Add support for Tegra210 ADMA Jon Hunter
[not found] ` <1444980919-20331-3-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-10-27 2:10 ` Vinod Koul
[not found] ` <20151027021008.GD11691-bQVUxfxUtC13uc1i7fC1zK2pdiUAq4bhAL8bYrjMMd8@public.gmane.org>
2015-10-27 9:24 ` Jon Hunter [this message]
2015-10-29 21:03 ` Andy Shevchenko
2015-11-02 16:22 ` Jon Hunter
[not found] ` <56378DB1.4020107-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-11-03 11:06 ` Jon Hunter
2015-10-28 13:17 ` Jon Hunter
[not found] ` <1444980919-20331-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-05-20 18:51 ` [PATCH V3 0/2] " Paul Gortmaker
2016-05-24 3:53 ` Vinod Koul
2016-05-24 11:19 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F42B1.30102@nvidia.com \
--to=jonathanh-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).