From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Alban Bedel
<alban.bedel-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [cbootimage PATCH 1/3] Fix the error reporting of get_bct_size_from_image()
Date: Wed, 11 Nov 2015 09:31:28 -0700 [thread overview]
Message-ID: <56436D60.80505@wwwdotorg.org> (raw)
In-Reply-To: <1446739402-14238-2-git-send-email-alban.bedel-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
On 11/05/2015 09:03 AM, Alban Bedel wrote:
> get_bct_size_from_image() should return negative error codes, so add
> the missing minus signs. Also fix the return value check on
> get_bct_size_from_image(), a negative value indicate an error not zero.
> diff --git a/src/data_layout.c b/src/data_layout.c
> @@ -1050,11 +1050,11 @@ int get_bct_size_from_image(build_image_context *context)
>
> fp = fopen(context->input_image_filename, "r");
> if (!fp)
> - return ENODATA;
> + return -ENODATA;
I see the exact same bug in read_bct_file() in the same source file.
Since that's the same logical bug, any chance you could fix that too in
the same patch?
next prev parent reply other threads:[~2015-11-11 16:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 16:03 [cbootimage PATCH 0/3] RSA on T124 and misc fixes Alban Bedel
[not found] ` <1446739402-14238-1-git-send-email-alban.bedel-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2015-11-05 16:03 ` [cbootimage PATCH 1/3] Fix the error reporting of get_bct_size_from_image() Alban Bedel
[not found] ` <1446739402-14238-2-git-send-email-alban.bedel-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2015-11-11 16:31 ` Stephen Warren [this message]
2015-11-05 16:03 ` [cbootimage PATCH 2/3] Fix image update with image smaller than 10KiB Alban Bedel
[not found] ` <1446739402-14238-3-git-send-email-alban.bedel-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2015-11-11 16:36 ` Stephen Warren
[not found] ` <56436E95.8000305-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-12-07 11:51 ` Alban Bedel
2015-12-07 17:20 ` Stephen Warren
[not found] ` <5665BFF8.5030205-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-12-08 14:27 ` Alban Bedel
2015-11-05 16:03 ` [cbootimage PATCH 3/3] Add support to read and write rsa related fields on t124 Alban Bedel
[not found] ` <1446739402-14238-4-git-send-email-alban.bedel-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2015-11-11 16:41 ` Stephen Warren
[not found] ` <56436FA4.3070906-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-11-11 16:56 ` Alban Bedel
2015-11-11 17:04 ` Stephen Warren
2015-11-11 16:30 ` [cbootimage PATCH 0/3] RSA on T124 and misc fixes Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56436D60.80505@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=alban.bedel-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).