linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rhyland Klein <rklein@nvidia.com>
To: Jon Hunter <jonathanh@nvidia.com>,
	Peter De Schrijver <pdeschrijver@nvidia.com>,
	Prashant Gaikwad <pgaikwad@nvidia.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Alexandre Courbot <gnurou@gmail.com>
Cc: linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] clk: tegra-super: Fix sparse warnings for functions not declared as static
Date: Mon, 7 Dec 2015 10:51:49 -0500	[thread overview]
Message-ID: <5665AB15.80602@nvidia.com> (raw)
In-Reply-To: <1449248665-22343-3-git-send-email-jonathanh@nvidia.com>

On 12/4/2015 12:04 PM, Jon Hunter wrote:
> Sparse reports the following warnings for structures and functions that
> should be declared static:
> 
> drivers/clk/tegra/clk-tegra-super-gen4.c:70:35: warning: symbol
>  'tegra_super_gen_info_gen4' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra-super-gen4.c:96:35: warning: symbol
>  'tegra_super_gen_info_gen5' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra-super-gen4.c:174:13: warning: symbol
>  'tegra_super_clk_init' was not declared. Should it be static?
> 
> Fix this by making the above static.
> 
> Fixes: 88467d220119 ("clk: tegra: Add Super Gen5 Logic")
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  drivers/clk/tegra/clk-tegra-super-gen4.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
...

Acked-by: Rhyland Klein <rklein@nvidia.com>

-- 
nvpublic

  reply	other threads:[~2015-12-07 15:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04 17:04 [PATCH 1/3] clk: tegra: Fix sparse warning for pll_m Jon Hunter
2015-12-04 17:04 ` [PATCH 2/3] clk: tegra210: Fix sparse warnings for functions not declared as static Jon Hunter
2015-12-07 15:51   ` Rhyland Klein
2015-12-04 17:04 ` [PATCH 3/3] clk: tegra-super: " Jon Hunter
2015-12-07 15:51   ` Rhyland Klein [this message]
     [not found]     ` <5665AB15.80602-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-12-07 17:51       ` Rhyland Klein
     [not found]         ` <5665C715.7030608-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-12-08  9:55           ` Jon Hunter
2015-12-07 15:50 ` [PATCH 1/3] clk: tegra: Fix sparse warning for pll_m Rhyland Klein
     [not found] ` <1449248665-22343-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-01-13 17:15   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5665AB15.80602@nvidia.com \
    --to=rklein@nvidia.com \
    --cc=gnurou@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=sboyd@codeaurora.org \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).