From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [PATCH v3] PCI: hosts: mark pcie/pci (msi) irq cascade handler as IRQF_NO_THREAD Date: Wed, 13 Jan 2016 20:48:03 +0200 Message-ID: <56969BE3.6000804@ti.com> References: <1449775100-30877-1-git-send-email-grygorii.strashko@ti.com> <20160106221827.GD16231@localhost> <20160113133904.GD29964@linutronix.de> <20160113175016.GB28453@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160113175016.GB28453@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Bjorn Helgaas , Sebastian Andrzej Siewior Cc: Krzysztof Kozlowski , linux-sh@vger.kernel.org, tony@atomide.com, linux-pci@vger.kernel.org, nsekhar@ti.com, Bjorn Helgaas , Thierry Reding , Alexandre Courbot , linux-samsung-soc@vger.kernel.org, Pratyush Anand , Michal Simek , Kishon Vijay Abraham I , Kukjin Kim , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , Stephen Warren , Simon Horman , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jingoo Han , Richard Zhu , linux-kernel@vger.kernel.org, Lucas Stach List-Id: linux-tegra@vger.kernel.org On 01/13/2016 07:50 PM, Bjorn Helgaas wrote: > On Wed, Jan 13, 2016 at 02:39:04PM +0100, Sebastian Andrzej Siewior wrote: >> * Bjorn Helgaas | 2016-01-06 16:18:27 [-0600]: >> >>> Hi Bjorn, >> >>>> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c >>>> index 8c36880..0415192 100644 >>>> --- a/drivers/pci/host/pci-dra7xx.c >>>> +++ b/drivers/pci/host/pci-dra7xx.c >>>> @@ -301,8 +301,19 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx, >>>> return -EINVAL; >>>> } >>>> >>>> + /* >>>> + * Mark dra7xx_pcie_msi IRQ as IRQF_NO_THREAD >>>> + * On -RT and if kernel is booting with "threadirqs" cmd line parameter >>>> + * the dra7xx_pcie_msi_irq_handler() will be forced threaded but, >>>> + * in the same time, it's IRQ dispatcher and calls generic_handle_irq(), >>>> + * which, in turn, will be resolved to handle_simple_irq() call. >>>> + * The handle_simple_irq() expected to be called with IRQ disabled, as >>>> + * result kernle will display warning: >>>> + * "irq XXX handler YYY+0x0/0x14 enabled interrupts". >>>> + */ >> >> could you _please_ remove this coment? This kind of comment (if at all) >> should be part of the commit message (which is the case more or less). > > IIRC, Grygorii specifically wanted to keep this comment in dra7xx, but True. > I do agree that this level of detail is more appropriate for a changelog. > > If Grygorii and Kishon don't object, I can update the patch to remove it. But no objections from my side. Thanks a lot. -- regards, -grygorii