Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm

Wei Ni
2016-02-15T07:19:27Z

On 2016年02月15日 15:15, Wei Ni wrote:
> Hi, Rob
>
> On 2016年02月12日 22:42, Rob Herring wrote:
>> On Fri, Jan 29, 2016 at 2:47 AM, Wei Ni <wni@nvidia.com> wrote:
>>> Add hw-trips sub-node for soctherm, which is
>>> used to describe the hardware trip points for
>>> each soctherm sensors.
>>
>> I still don't understand why you are doing something custom here.
>> What's wrong with what is defined in:
>>
>> Documentation/devicetree/bindings/thermal/thermal.txt
>
> In current thermal framework, it support to set trip points for the thermal
> zones, but this trip point is handled by SW, doesn't have callbacks to program
> the hardware.
> There had patches:
> [PATCH 12/16] thermal: thermal: Add support for hardware-tracked trip points,
> http://lists.infradead.org/pipermail/linux-mediatek/2015-May/000866.html,
> which can support to program hardware to set trip points, but it seems this
> series didn't be taken.
> So I add this hw-trip-points sub-node for soctherm.
>
> Hi, Sascha Hauer

Hi, Sasha
Sorry, I forgot to type messages in previous mail.

I noticed that you submitted "[PATCH 12/16] thermal: thermal: Add support for
hardware-tracked trip points" long time ago, I think it's very useful, do you
know why it didn't be taken?

>
> Thanks.
> Wei.
>
>>
>> Rob
>>