Re: regulator: core: Request GPIO before creating sysfs entries

Krzysztof Adamski
2016-02-23T13:56:51Z

On Tue, Feb 23, 2016 at 01:22:38PM +0000, Jon Hunter wrote:
>Hi Mark, Krzysztof,
>
>It appears that commit daad134d6649 ("regulator: core: Request GPIO
>before creating sysfs entries") breaks boot on tegra124-nyan-big in
>-next today.
>
>Looking at the change, it does not appear that the exit path has been
>updated correctly and so if a regulator is deferred then there is a
>crash in the exit path. I am not sure that there is a simple way to
>workaround this because of fix from commit 53032dafc6b9 ("regulator
>core: fix double-free in regulator_register() error path") unless we
>move regulator_ena_gpio_free() into regulator_dev_release().

Hi Jon,

You are totally right about the problem but I can't see why changing
"goto wash" to "goto clean" in error path of regulator_ena_gpio_request
is not enough. What am I missing?

Best regards,
Krzysztof Adamski