From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Ni Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature Date: Mon, 7 Mar 2016 17:16:03 +0800 Message-ID: <56DD46D3.3060708@nvidia.com> References: <1456739480-3304-1-git-send-email-wni@nvidia.com> <56D698FE.7070706@nvidia.com> <56D78081.6050106@nvidia.com> <56DD3B1E.4030805@nvidia.com> <744357E9AAD1214791ACBA4B0B9092633A9721DE@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <744357E9AAD1214791ACBA4B0B9092633A9721DE-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Zhang, Rui" , "thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "mikko.perttunen-/1wQRMveznE@public.gmane.org" , Eduardo Valentin Cc: Matt Longnecker , "swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On 2016=E5=B9=B403=E6=9C=8807=E6=97=A5 16:55, Zhang, Rui wrote: > For the soc thermal driver changes, you'd better cc Eduardo at the sa= me time so that he can include this in his soc-thermal pull request. > Surely I can queue this for 4.6 if Eduardo miss this. Thanks for your help. BTW, please add: Reviewed-by: Matt Longnecker Or I need to send v2 patch to add it? Thanks. Wei. >=20 > Thanks, > rui >=20 >> -----Original Message----- >> From: Wei Ni [mailto:wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org] >> Sent: Monday, March 07, 2016 4:26 PM >> To: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; Zhang, Rui ; >> mikko.perttunen-/1wQRMveznE@public.gmane.org >> Cc: Matt Longnecker ; swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org; >> linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temper= ature >> Importance: High >> >> Hi, Rui and Thierry >> Could you please take a look at this patch? >> >> Thanks. >> Wei. >> >> On 2016=E5=B9=B403=E6=9C=8803=E6=97=A5 08:08, Matt Longnecker wrote: >>> >>> >>> On 03/01/2016 11:40 PM, Wei Ni wrote: >>>>> diff --git a/drivers/thermal/tegra_soctherm.c >> b/drivers/thermal/tegra_soctherm.c >>>>> index 74ea5765938b..136975220c92 100644 >>>>> --- a/drivers/thermal/tegra_soctherm.c >>>>> +++ b/drivers/thermal/tegra_soctherm.c >>>>> @@ -57,7 +57,7 @@ >>>>> #define READBACK_VALUE_MASK 0xff00 >>>>> #define READBACK_VALUE_SHIFT 8 >>>>> #define READBACK_ADD_HALF BIT(7) >>>>> -#define READBACK_NEGATE BIT(1) >>>>> +#define READBACK_NEGATE BIT(0) >>> I confirm that this change is technically correct. It fixes a bug.