Re: [PATCH V7 08/12] of: add notes of critical trips for soctherm

Eduardo Valentin
2016-03-15T19:52:00Z

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

On Tue, Mar 15, 2016 at 04:14:15PM +0800, Wei Ni wrote:
>
>
> On 2016年03月15日 15:49, Wei Ni wrote:
> >
> >
> > On 2016年03月15日 05:00, Eduardo Valentin wrote:
> >> * PGP Signed by an unknown key
> >>
> >> On Fri, Mar 11, 2016 at 11:11:00AM +0800, Wei Ni wrote:
> >>> The "critical" type trip in thermal zone can be
> >>> set to SOC_THERM hardware, it can trigger shut down
> >>> or reset event from hardware.
> >>>
> >>> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >>> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> >>> ---
> >>> Documentation/devicetree/bindings/thermal/tegra-soctherm.txt | 12 ++++++++++++
> >>> 1 file changed, 12 insertions(+)
> >>
> >> I did not see in your patch set an update on the compatible string for
> >> the new chip. Did I miss something?
> >
> > As I said in the previous [00/12], the "commit 193c9d23a0f0" already added the
> > compatible string. At that time, it just used current tegra_soctherm.c driver to
> > support Tegra210, it can work, but can't show temperatures correctly.
>
> Oh, sorry, I made a mistake, this "commit 193c9d23a0f0" just added the
> compatible string, did not use current tegra_soctherm driver to support Tegra210.

Ok. got it. The binding is done, but the driver is being re factored only
now to add the support for this chip version.

>
> Wei.
>
> >
> >>
> >> * Unknown Key
> >> * 0x7DA4E256
> >>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]