public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [pinmux scripts PATCH] soc: Add support for Parked bits for Tegra210
Date: Thu, 7 Apr 2016 14:35:01 -0600	[thread overview]
Message-ID: <5706C475.7010102@wwwdotorg.org> (raw)
In-Reply-To: <1460060143-25086-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 04/07/2016 02:15 PM, Rhyland Klein wrote:
> Tegra210 has a parked bit for each pin. Add code to express
> this by updating the kernel driver MACROs to add in parked_*
> fields so that the kernel can handle them as it sees fit.

I'd expect that wrapped around 74 characters. Our internal git 
auto-review thing's 50-character limit is a bit odd (I think it's only 
meant to apply to the synopsis not the full description but is either 
buggy or just doesn't make that clear).

> diff --git a/configs/tegra114.soc b/configs/tegra114.soc

> +soc_pins_have_parked = False
>   soc_drv_reg_base = 0x868
>   soc_einput_b = 5
>   soc_odrain_b = 6
> +soc_parked_bank = 0
> +soc_parked_bit = 0

For SoCs with soc_pins_have_parked == False, can we simply omit the 
bank/bit values from the config file?

Other than that, I think this looks good. Thanks for taking the time to 
update it.

  parent reply	other threads:[~2016-04-07 20:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 20:15 [pinmux scripts PATCH] soc: Add support for Parked bits for Tegra210 Rhyland Klein
     [not found] ` <1460060143-25086-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-07 20:35   ` Stephen Warren [this message]
     [not found]     ` <5706C475.7010102-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-04-07 20:42       ` Rhyland Klein
     [not found]         ` <5706C634.80605-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-07 20:49           ` Stephen Warren
     [not found]             ` <5706C7D3.9030407-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-04-07 20:51               ` Rhyland Klein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5706C475.7010102@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox