Re: [pinmux scripts PATCH] soc: Add support for Parked bits for Tegra210

[Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]

On 4/7/2016 4:35 PM, Stephen Warren wrote:
> On 04/07/2016 02:15 PM, Rhyland Klein wrote:
>> Tegra210 has a parked bit for each pin. Add code to express
>> this by updating the kernel driver MACROs to add in parked_*
>> fields so that the kernel can handle them as it sees fit.
> 
> I'd expect that wrapped around 74 characters. Our internal git 
> auto-review thing's 50-character limit is a bit odd (I think it's only 
> meant to apply to the synopsis not the full description but is either 
> buggy or just doesn't make that clear).

I'll fix the wrapping.

> 
>> diff --git a/configs/tegra114.soc b/configs/tegra114.soc
> 
>> +soc_pins_have_parked = False
>>   soc_drv_reg_base = 0x868
>>   soc_einput_b = 5
>>   soc_odrain_b = 6
>> +soc_parked_bank = 0
>> +soc_parked_bit = 0
> 
> For SoCs with soc_pins_have_parked == False, can we simply omit the 
> bank/bit values from the config file?

I tried that originally, but I don't think I can. The reason is that
tegra_pmx_soc_parser uses a predefined array of attributes (copy_attrs)
and if the entry isn't in that, then it won't be populated and can't be
accessed later to fill in the values for say T210. If the entry IS in
the copy_attrs, then the script will fail if there isn't an entry in the
config file. Its unfortunate, and maybe someone more familiar with the
scripts might know of a way to get around this, something I haven't
found yet.

-rhyland

-- 
nvpublic