From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] dt-bindings: tegra: Rename some bindings for consistency
Date: Mon, 11 Apr 2016 09:58:14 -0600 [thread overview]
Message-ID: <570BC996.3050804@wwwdotorg.org> (raw)
In-Reply-To: <1460383086-26957-2-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 04/11/2016 07:58 AM, Thierry Reding wrote:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Device tree binding for NVIDIA Tegra have traditionally carried the
> "nvidia," vendor prefix in the filename. A couple of odd ones don't, so
> fix them up for consistency.
>
> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> .../devicetree/bindings/ata/nvidia,tegra-ahci.txt | 32 ++
> .../devicetree/bindings/ata/tegra-sata.txt | 32 --
> .../bindings/dma/nvidia,tegra20-apbdma.txt | 44 +++
> .../devicetree/bindings/dma/tegra20-apbdma.txt | 44 ---
> .../memory-controllers/nvidia,tegra-emc.txt | 374 +++++++++++++++++++++
> .../bindings/memory-controllers/tegra-emc.txt | 374 ---------------------
> .../bindings/thermal/nvidia,tegra-soctherm.txt | 67 ++++
> .../devicetree/bindings/thermal/tegra-soctherm.txt | 67 ----
> 8 files changed, 517 insertions(+), 517 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.txt
The filenames should exactly match the (first) compatible value they
document for consistency with other bindings. That should be
nvidia,tegra124-ahci.txt.
> delete mode 100644 Documentation/devicetree/bindings/ata/tegra-sata.txt
> create mode 100644 Documentation/devicetree/bindings/dma/nvidia,tegra20-apbdma.txt
> delete mode 100644 Documentation/devicetree/bindings/dma/tegra20-apbdma.txt
> create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra-emc.txt
That should be nvidia,tegra124-emc.txt.
> delete mode 100644 Documentation/devicetree/bindings/memory-controllers/tegra-emc.txt
> create mode 100644 Documentation/devicetree/bindings/thermal/nvidia,tegra-soctherm.txt
> delete mode 100644 Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
That should be nvidia,tegra124-soctherm.txt.
I assume the delete/create content is identical, although I didn't both
to check.
With the fixes above,
Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
next prev parent reply other threads:[~2016-04-11 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 13:58 [PATCH 1/2] dt-bindings: tegra: Remove 0, prefix from unit-addresses Thierry Reding
[not found] ` <1460383086-26957-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-04-11 13:58 ` [PATCH 2/2] dt-bindings: tegra: Rename some bindings for consistency Thierry Reding
[not found] ` <1460383086-26957-2-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-04-11 15:58 ` Stephen Warren [this message]
2016-04-12 1:28 ` Joseph Lo
[not found] ` <570C4F2F.8050407-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-12 2:26 ` Stephen Warren
[not found] ` <570C5CD6.2090700-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-04-12 15:08 ` Thierry Reding
2016-04-11 15:55 ` [PATCH 1/2] dt-bindings: tegra: Remove 0, prefix from unit-addresses Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570BC996.3050804@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox