From: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice
Date: Thu, 5 May 2016 18:10:04 +0100 [thread overview]
Message-ID: <572B7E6C.5070201@nvidia.com> (raw)
In-Reply-To: <572B7D48.6010807-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 05/05/16 18:05, Jon Hunter wrote:
[snip]
> I spent a bit of time looking at this to figure out what it is doing. Can we simply
> this a bit as follows (limited testing so far) ...
>
> Cheers
> Jon
>
> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> index c1c1024a054c..70501053e1ec 100644
> --- a/drivers/usb/host/ehci-tegra.c
> +++ b/drivers/usb/host/ehci-tegra.c
> @@ -81,15 +81,25 @@ static int tegra_reset_usb_controller(struct platform_device *pdev)
> struct usb_hcd *hcd = platform_get_drvdata(pdev);
> struct tegra_ehci_hcd *tegra =
> (struct tegra_ehci_hcd *)hcd_to_ehci(hcd)->priv;
> + bool has_utmi_pad_registers = false;
> + dev_info(&pdev->dev, "%s-%d\n", __func__, __LINE__);
Oops, some left over debug I meant to remove :-p
Jon
next prev parent reply other threads:[~2016-05-05 17:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 14:39 [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset Thierry Reding
[not found] ` <1462372800-30900-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-04 14:40 ` [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice Thierry Reding
[not found] ` <1462372800-30900-2-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-04 17:22 ` Philipp Zabel
2016-05-04 20:16 ` Thierry Reding
2016-05-04 17:23 ` Stephen Warren
[not found] ` <572A3008.4020602-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-05-04 20:25 ` Thierry Reding
2016-05-05 8:05 ` Hans de Goede
[not found] ` <fdf3583d-636e-5619-5df6-17b6ae331ac9-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-05-05 16:00 ` Stephen Warren
[not found] ` <572B6E1B.3060901-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-05-05 17:12 ` Hans de Goede
2016-05-05 17:05 ` Jon Hunter
[not found] ` <572B7D48.6010807-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-05-05 17:10 ` Jon Hunter [this message]
2016-05-04 14:57 ` [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset Greg Kroah-Hartman
[not found] ` <20160504145710.GA14708-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-05-04 15:26 ` Thierry Reding
[not found] ` <20160504152648.GA31420-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2016-05-05 16:05 ` Tuomas Tynkkynen
2016-05-04 17:14 ` Stephen Warren
[not found] ` <572A2E0A.8040408-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-05-04 20:30 ` Thierry Reding
2016-05-05 7:39 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572B7E6C.5070201@nvidia.com \
--to=jonathanh-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).