From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH 3/3] irqchip/gic-pm: use devm_clk_*() helpers Date: Wed, 6 Mar 2019 12:00:02 +0000 Message-ID: <573022cf-e2e3-0e12-d16c-6d465b8af2ce@nvidia.com> References: <1551868878-1131-1-git-send-email-spujar@nvidia.com> <1551868878-1131-3-git-send-email-spujar@nvidia.com> <487578fe-fa14-f1c4-fad9-ff47ebde2273@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <487578fe-fa14-f1c4-fad9-ff47ebde2273@arm.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Marc Zyngier , Sameer Pujar , vkoul@kernel.org, dan.j.williams@intel.com, tglx@linutronix.de, jason@lakedaemon.net Cc: thierry.reding@gmail.com, ldewangan@nvidia.com, mkumard@nvidia.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On 06/03/2019 11:31, Marc Zyngier wrote: > Hi Sameer, > > [unrelated to this email: anything that comes from NVIDIA reaches me > encrypted with my public key. Not a big deal, but it'd be good if > someone could fix that.] > > On 06/03/2019 10:41, Sameer Pujar wrote: >> With pm_clk_*() usage, it is seen that clocks always remain ON. This >> happens because clocks are managed by BPMP on Tegra devices and clock >> enable/disable happens during prepare/unprepare phase. This patch >> avoids use of pm_clk_*() and replaces it with devm_clk_*() helpers. >> >> Suggested-by: Mohan Kumar D >> Reviewed-by: Jonathan Hunter >> Signed-off-by: Sameer Pujar > > On its own, I'm not opposed to that patch. > > But given that there is no in-tree platform using this, despite the code > sitting here for more than 2.5 years, this is just updating dead code. > > Am I missing anything? Nope, but we are working to fix that at long last. I hope in the next few months it will not longer be dormant! This driver is still very much important to our audio support for newer Tegra devices. Cheers Jon -- nvpublic