From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH V4 3/3] soc/tegra: pmc: Add support for IO pads power state and voltage Date: Wed, 11 May 2016 22:52:10 +0530 Message-ID: <57336A42.3090507@nvidia.com> References: <1462531548-12914-1-git-send-email-ldewangan@nvidia.com> <1462531548-12914-4-git-send-email-ldewangan@nvidia.com> <572CAC20.9030307@nvidia.com> <572CB906.3090004@nvidia.com> <572F2D84.3060505@nvidia.com> <57333366.2040500@nvidia.com> <5733513E.9080606@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5733513E.9080606-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jon Hunter , thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Wednesday 11 May 2016 09:05 PM, Jon Hunter wrote: > On 11/05/16 14:28, Laxman Dewangan wrote: >> On Sunday 08 May 2016 05:43 PM, Jon Hunter wrote: >>> On 06/05/16 16:32, Laxman Dewangan wrote: >>>> On Friday 06 May 2016 08:07 PM, Jon Hunter wrote: >>>>> On 06/05/16 11:45, Laxman Dewangan wrote: >>>>> + >>>>> + /* Last entry */ >>>>> + TEGRA_IO_PAD_MAX, >>>>> Nit should these be TEGRA_IO_PADS_xxx? >>>> Because this was name of single pad and hence I said TEGRA_IO_PAD_XXX. >>> Aren't these used to set the voltage level and power state for the >>> entire group of IOs? Confused :-( >> One IO pad can have multiple IO pins. >> IO Pad control the power state and voltage of all pins belongs to that >> IO pad. > Ugh ... I remember for xusb there was something similar we the Tegra > docs used pad to imply multiple. However, in general pad == pin == ball > or at least should. when we say sddmc3 IO pads, we deal with all signal pins of sdmm3.