From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH] ARM: tegra: fix missing include Date: Fri, 10 Jun 2016 15:33:25 +0100 Message-ID: <575ACFB5.4070706@nvidia.com> References: <1465404897-16654-1-git-send-email-ben.dooks@codethink.co.uk> <20160610142210.GN27142@ulmo.ba.sec> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160610142210.GN27142-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding , Ben Dooks Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org, Stephen Warren , Alexandre Courbot , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 10/06/16 15:22, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote: >> The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing >> from the cpuidle.c file, it is defined in >> so add that include to avoid the following warning: >> >> arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static? >> >> Signed-off-by: Ben Dooks >> --- >> Cc: Stephen Warren >> Cc: Alexandre Courbot >> Cc: Thierry Reding >> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org >> Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> --- >> arch/arm/mach-tegra/cpuidle.c | 1 + >> 1 file changed, 1 insertion(+) > > I've been carrying a set of patches to fix these, and a couple of other > sparse warnings, in my tree locally, but never sent them out because > they were so trivial. I probably should've to avoid the duplication of > effort. Sorry about that. I think you did send them out ;-) http://patchwork.ozlabs.org/patch/616249/ http://patchwork.ozlabs.org/patch/616250/ http://patchwork.ozlabs.org/patch/616251/ http://patchwork.ozlabs.org/patch/616252/ Jon -- nvpublic