From: Laxman Dewangan <ldewangan@nvidia.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joe Perches <joe@perches.com>, Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH V3 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads
Date: Thu, 24 Nov 2016 19:49:54 +0530 [thread overview]
Message-ID: <5836F70A.9070109@nvidia.com> (raw)
In-Reply-To: <CACRpkdbp8_eR7PLoaX4AJbhcx_tYQjcS5U_hR3EU7b4dar3ckg@mail.gmail.com>
On Thursday 24 November 2016 07:41 PM, Linus Walleij wrote:
> On Wed, Nov 23, 2016 at 12:42 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>> Here, we need the regulator handle which can support the other regulator
>> APIs.
>>
>> In some of platforms, we do not use some of the io-pins and on this case, we
>> do not connect the IO rail supply for these pins. So this is like a hardware
>> optional.
>>
>> If the IO pins are used then it need to have the proper regulator handle.
>> Missing regulator handle on DT will be like that IO pads are not used.
> OK I buy that argument, unless Mark (Brown) has comments.
>
BTW, I resolved this in different way in V4 which I sent today, if
regulator_get() succeed for dummy then regulator_get_voltage() failed
and if it failed then assume that it is dummy and just ignore the
further handling based on regulator.
So when we really need the configuration based on voltage, we must
supply the regulator handle.
prev parent reply other threads:[~2016-11-24 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 10:20 [PATCH V3 0/2] pinctrl: tegra: Add support for IO pad control Laxman Dewangan
2016-11-22 10:20 ` [PATCH V3 1/2] pinctrl: tegra: Add DT binding for io pads control Laxman Dewangan
[not found] ` <1479810013-29894-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-11-22 10:20 ` [PATCH V3 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads Laxman Dewangan
2016-11-22 12:58 ` Linus Walleij
[not found] ` <CACRpkdZK34QfbSBJvshfZekk5TJBU5sZog-9uszLSmFPOGJgiw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-23 11:42 ` Laxman Dewangan
2016-11-24 14:11 ` Linus Walleij
2016-11-24 14:19 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5836F70A.9070109@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=joe@perches.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).