From: Florian Fainelli <f.fainelli@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ARM: tegra: Fix misplaced tegra_uart_config in decompressor
Date: Tue, 15 Dec 2020 08:40:06 -0800 [thread overview]
Message-ID: <5853b349-562c-3b6a-33d6-49516553dad8@gmail.com> (raw)
In-Reply-To: <5b01ce96-5f8b-dfcb-accd-2ba29f34947f@gmail.com>
On 12/15/2020 8:17 AM, Dmitry Osipenko wrote:
> 15.12.2020 19:04, Florian Fainelli пишет:
>>
>>
>> On 12/15/2020 5:52 AM, Dmitry Osipenko wrote:
>>> The tegra_uart_config of the DEBUG_LL code is now placed right at the
>>> start of the .text section after commit which enabled debug output in the
>>> decompressor. Tegra devices are not booting anymore if DEBUG_LL is enabled
>>> since tegra_uart_config data is executes as a code. Fix the misplaced
>>> tegra_uart_config storage by embedding it into the code.
>>>
>>> Cc: stable@vger.kernel.org
>>> Fixes: 2596a72d3384 ("ARM: 9009/1: uncompress: Enable debug in head.S")
>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>>> ---
>>> arch/arm/include/debug/tegra.S | 54 +++++++++++++++++-----------------
>>> 1 file changed, 27 insertions(+), 27 deletions(-)
>>
>> Looks like arch/arm/include/debug/brcmstb.S would need the same
>> treatment since the implementation was copied from tegra.S.
>>
>
> Good catch, will you be able to test the brcm and make a patch?
Yes, absolutely, building a kernel to test right now.
--
Florian
next prev parent reply other threads:[~2020-12-15 16:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 13:52 [PATCH v1] ARM: tegra: Fix misplaced tegra_uart_config in decompressor Dmitry Osipenko
2020-12-15 14:28 ` Linus Walleij
2020-12-15 15:20 ` Dmitry Osipenko
2020-12-15 16:04 ` Florian Fainelli
2020-12-15 16:17 ` Dmitry Osipenko
2020-12-15 16:40 ` Florian Fainelli [this message]
2020-12-15 16:53 ` Dmitry Osipenko
2020-12-15 18:22 ` Florian Fainelli
2020-12-15 18:56 ` Dmitry Osipenko
2020-12-15 19:20 ` Florian Fainelli
2020-12-15 19:47 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5853b349-562c-3b6a-33d6-49516553dad8@gmail.com \
--to=f.fainelli@gmail.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox