From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH v2 3/7] soc/tegra: pmc: Implement
 tegra_io_pad_is_powered()
Date: Thu, 12 Jul 2018 11:10:03 +0100
Message-ID: <5e041bd6-d152-30a9-e2f8-48552e50ccee@nvidia.com>
References: <1531317693-3520-1-git-send-email-avienamo@nvidia.com>
 <1531317693-3520-4-git-send-email-avienamo@nvidia.com>
 <3ced704b-2a8b-b78c-3b1e-6c2d7562edcc@nvidia.com>
 <2d669942-0b4d-f48b-a8ba-67794485bf5f@nvidia.com>
 <20180712105247.121a5d13@dhcp-10-21-25-168>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20180712105247.121a5d13@dhcp-10-21-25-168>
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
To: Aapo Vienamo <avienamo@nvidia.com>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Thierry Reding <thierry.reding@gmail.com>, Mikko Perttunen <mperttunen@nvidia.com>, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
List-Id: linux-tegra@vger.kernel.org


On 12/07/18 08:52, Aapo Vienamo wrote:
> On Wed, 11 Jul 2018 16:26:42 +0100
> Jon Hunter <jonathanh@nvidia.com> wrote:
> 
>> On 11/07/18 16:23, Jon Hunter wrote:
>>>
>>> On 11/07/18 15:01, Aapo Vienamo wrote:  
>>>> Implement a function to query whether a pad is in deep power down mode.  
>>> Can you elaborate on why this public function is needed and who will be
>>> using this?  
>>
>> Or I should say does this need to be public?
> 
> It's only called from the pinconf callbacks and exposing it doesn't
> indeed make much sense if we intend to replace direct calls to pmc.c
> with pinctrl anyway. I'll make it private on the next iteration of the
> series.

Yes let's make it private.

Cheers
Jon

-- 
nvpublic