From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH] clk: tegra210: Fix default rates for HDA clocks Date: Fri, 31 May 2019 15:58:53 +0100 Message-ID: <5f2b8f8d-f3e5-fab8-8cf0-fa8a3e917845@nvidia.com> References: <1559121501-8566-1-git-send-email-jonathanh@nvidia.com> <20190529134625.GD17223@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190529134625.GD17223@ulmo> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Thierry Reding Cc: Peter De Schrijver , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Sameer Pujar List-Id: linux-tegra@vger.kernel.org On 29/05/2019 14:46, Thierry Reding wrote: > On Wed, May 29, 2019 at 10:18:21AM +0100, Jon Hunter wrote: >> Currently the default clock rates for the HDA and HDA2CODEC_2X clocks >> are both 19.2MHz. However, the default rates for these clocks should >> actually be 51MHz and 48MHz, respectively. Correct the default clock >> rates for these clocks by specifying them in the clock init table for >> Tegra210. >> >> Signed-off-by: Jon Hunter >> --- >> drivers/clk/tegra/clk-tegra210.c | 2 ++ >> 1 file changed, 2 insertions(+) > > Does this fix anything? Should this be backported to stable releases? Good point. We are aligning the clock configuration with what we ship. So I thought for completeness it would be good to test HDA playback across the various sample-rates we support (32kHz to 192kHz) but with or without this patch I am not hearing anything. Let me check on this with Sameer as I would like to see if we need to mark this for stable or not. > Acked-by: Thierry Reding Thanks Jon -- nvpublic